Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep share dropdown open while loading #38729

Closed
wants to merge 1 commit into from
Closed

Keep share dropdown open while loading #38729

wants to merge 1 commit into from

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jun 9, 2023

Summary

Checklist

@Pytal
Keep share dropdown open while loading
1fadc3c 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added design Design, UI, UX, etc. 3. to review Waiting for reviews feature: sharing feature: file sidebar Related to the file sidebar component labels Jun 9, 2023
@Pytal Pytal added this to the Nextcloud 28 milestone Jun 9, 2023
@Pytal Pytal self-assigned this Jun 9, 2023
@Pytal
Copy link
Member Author

Pytal commented Jun 9, 2023

/backport to stable27

@Pytal
Copy link
Member Author

Pytal commented Jun 9, 2023

/backport to stable26

@Pytal
Copy link
Member Author

Pytal commented Jun 9, 2023

/backport to stable25

szaimen
szaimen approved these changes Jun 10, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to fix the problem in my testing. Thanks a lot for fixing this so fast Chris! :)

@artonge
Copy link
Contributor

artonge commented Jun 12, 2023

Shouldn't it be fixed on the @nc/vue side?

@nimishavijay nimishavijay mentioned this pull request Jun 12, 2023
Closed
4 tasks
@Pytal
Copy link
Member Author

Pytal commented Jun 13, 2023

Superseded by nextcloud-libraries/nextcloud-vue#4209

@Pytal Pytal closed this Jun 13, 2023
@szaimen szaimen deleted the enh/share-select-open branch June 13, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@artonge artonge Awaiting requested review from artonge

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews design Design, UI, UX, etc. feature: file sidebar Related to the file sidebar component feature: sharing
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

the NCSelect should not close and keep displaying current results until it has found new results
4 participants
@Pytal @artonge @szaimen @skjnldsv