Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(NcSelect): Keep dropdown open while loading #4209

Merged
merged 1 commit into from
Jun 13, 2023
Merged

enh(NcSelect): Keep dropdown open while loading #4209

merged 1 commit into from
Jun 13, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Jun 13, 2023

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@Pytal Pytal added enhancement New feature or request 3. to review Waiting for reviews design Design, UX, interface and interaction design feature: select Related to the NcSelect* components labels Jun 13, 2023
@Pytal Pytal added this to the 8.0.0 milestone Jun 13, 2023
@Pytal Pytal self-assigned this Jun 13, 2023
@Pytal Pytal mentioned this pull request Jun 13, 2023
Closed
4 tasks
szaimen
szaimen approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

nimishavijay
nimishavijay approved these changes Jun 13, 2023
View reviewed changes
Copy link

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in the screenshot :)

@Pytal
enh(NcSelect): Keep dropdown open while loading
23e67f6 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/select-dropdown-open branch from 350fe8e to 23e67f6 Compare June 13, 2023 18:07
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 13, 2023
@Pytal Pytal merged commit 287e71f into master Jun 13, 2023
@Pytal Pytal deleted the enh/select-dropdown-open branch June 13, 2023 18:10
@Pytal Pytal mentioned this pull request Jun 13, 2023
Closed
4 tasks
@skjnldsv skjnldsv mentioned this pull request Jun 28, 2023
Merged
@szaimen szaimen mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimishavijay nimishavijay nimishavijay approved these changes

@szaimen szaimen szaimen approved these changes

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UX, interface and interaction design enhancement New feature or request feature: select Related to the NcSelect* components
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

the NCSelect should not close and keep displaying current results until it has found new results
4 participants
@Pytal @artonge @szaimen @nimishavijay