Sort tags #38066
Closed
Sort tags #38066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 4, 2023
|
This should fail with P.S.: Or rather |
skjnldsv
approved these changes
May 4, 2023
skjnldsv
requested changes
May 4, 2023
icewind1991
approved these changes
May 4, 2023
|
Will push fix |
|
Done |
skjnldsv
approved these changes
May 4, 2023
skjnldsv
added
4. to release
|
#38067 is probably the better place to do the sorting |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+62
to
+64
| usort($this->tags, function(SystemTag $a, SystemTag $b) { | ||
| return strnatcmp($a->getName(), $b->getName()); | ||
| }); |
Check notice
Code scanning / Psalm
ArgumentTypeCoercion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sorts tags before returning via webdav
Checklist