Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tags in file/folder listing #39

Closed
7 tasks done
tobiasKaminsky opened this issue Apr 5, 2023 · 15 comments
Closed
7 tasks done

Show tags in file/folder listing #39

tobiasKaminsky opened this issue Apr 5, 2023 · 15 comments
Assignees
Labels
enhancement New feature or request

Comments

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Apr 5, 2023

Server:
Webdav property is: "tags".
Output:

<nc:sharees/>
<nc:tags>
  <oc:tag>test 0</oc:tag>
</nc:tags>

Android/iOS @tobiasKaminsky @marinofaggiana:

  • show first tag as first entry in subline
  • if more "+x"
  • ellipsize tags
  • use rounded borders similar to mockup below
  • show all tags in details

Desktop @claucambra :
in activity list (ping @nickvergessen if API change in needed), in subline, same as Android/iOS

  • share options/file detail: beneath size/date
  • use rounded borders similar to mockup below

Mockup:
image

@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (dont pick) in 🤖 🍏 Clients team Apr 5, 2023
@tobiasKaminsky tobiasKaminsky moved this from 🧭 Planning evaluation (dont pick) to 🏗️ In progress in 🤖 🍏 Clients team Apr 5, 2023
@tobiasKaminsky
Copy link
Member Author

@marino you can use our e2e.kaminsky.me test server with PROPFIND:

PROPFIND with
results in:

nc:tags
oc:tagtest 0</oc:tag>
oc:tagtest 1</oc:tag>
oc:tagtest 2</oc:tag>
oc:tagtest 3</oc:tag>
</nc:tags>
(nc vs oc might change, as this is strange right now)

@marinofaggiana marinofaggiana self-assigned this Apr 10, 2023
@marinofaggiana
Copy link
Member

Screenshot 2023-04-10 alle 15 31 34

@marinofaggiana
Copy link
Member

@tobiasKaminsky but for added / select a tag ?

@tobiasKaminsky
Copy link
Member Author

Right now it is only for showing tags.
Nothing more is needed :)

@marinofaggiana
Copy link
Member

ok

@tobiasKaminsky
Copy link
Member Author

iOS:
image

Android:
image

@jancborchardt I am unsure if two lines will fit…It will then look on iOS also cluttered, same as on Android…

@claucambra
Copy link

Opened nextcloud/desktop#5596

@claucambra
Copy link

iOS: image

Android: image

@jancborchardt I am unsure if two lines will fit…It will then look on iOS also cluttered, same as on Android…

Note we will have the same issue on activities on desktop, particularly for those that are already showing changes to several files

@marinofaggiana
Copy link
Member

Yes ... isn't good ...

@jancborchardt
Copy link
Member

Yeah, we should definitely not have multiple sublines.

How about if there are tags on a file, we just replace the current subline info about file size and date with the tags?
Everything is still visible in the details.

We just need to make sure the tag text is on the same baseline as the current date and time text so it looks nice.
And the border of the tags can also be a bit lighter to look less busy.

@marinofaggiana
Copy link
Member

marinofaggiana commented Apr 12, 2023

@jancborchardt

Screenshot 2023-04-12 alle 15 44 39

Simulator Screenshot - iPhone 14 - 2023-04-12 at 15 44 51

@tobiasKaminsky
Copy link
Member Author

How about if there are tags on a file, we just replace the current subline info about file size and date with the tags?
Everything is still visible in the details.

Nice idea. Shall we then still only have one tag? and then "+x" as second?
Or shall we have 2 tags and then "+x"?
(I have no idea how many tags usually are used…)

@tobiasKaminsky
Copy link
Member Author

2023-04-12-160006

@jancborchardt
Copy link
Member

We can definitely show more than one tag, however much space there is of course.

@tobiasKaminsky for Android the border color of the tag can be a bit lighter, and the tags are a bit too low compared to the size/date text.

@marinofaggiana for iOS it looks nice in the file list, good job! Can you there also show more than just 1 tag? 2 at least we could show, of course depending on length of text. :)

@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Apr 18, 2023

@marinofaggiana @claucambra we now have official API:
PROPFIND with < system-tags xmlns="http://nextcloud.org/ns"/ >
results in:

<nc:system-tags>
					<nc:system-tag oc:can-assign="true" oc:id="3" oc:user-assignable="true" oc:user-visible="true">important</nc:system-tag>
				</nc:system-tags>

For us, right now, only name is important.

You can test it/use it on:
e2e.kaminsky.me
user: tag

@jancborchardt jancborchardt moved this to 🏗️ At engineering in 🖍 Design team May 11, 2023
@AndyScherzinger AndyScherzinger added the enhancement New feature or request label May 11, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 🤖 🍏 Clients team May 17, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ At engineering to 🎉 Done in 🖍 Design team May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Archived in project
Development

No branches or pull requests

5 participants