Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calendar emails to be outlook compatible #36118

Merged
merged 1 commit into from
May 10, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jan 12, 2023

Summary

Resubmit and formatted version of #34324

Checklist

@ChristophWurst
Copy link
Member Author

@miaulalala would this be realistic to finish for 26?

@miaulalala
Copy link
Contributor

Questionable if symfony supports this: symfony/symfony#44557

I will look into it tomorrow

@blizzz blizzz mentioned this pull request Feb 1, 2023
@miaulalala miaulalala force-pushed the fix/caldav/invitation-outlook-compatibilty branch from f7a53e7 to cfa3473 Compare February 20, 2023 17:24
@miaulalala
Copy link
Contributor

The attachment is embedded now, but I have no outlook client to test this. @merlinwoff can you please try?

@ChristophWurst
Copy link
Member Author

The rebase went sideways

@miaulalala miaulalala force-pushed the fix/caldav/invitation-outlook-compatibilty branch 2 times, most recently from 9842ac2 to 460a8b2 Compare February 20, 2023 17:58
Copy link
Member Author

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥲

lib/public/Mail/IMessage.php Outdated Show resolved Hide resolved
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the fix/caldav/invitation-outlook-compatibilty branch from ac79181 to ed70815 Compare February 21, 2023 13:37
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@blizzz blizzz mentioned this pull request Mar 7, 2023
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Mar 17, 2023
This was referenced May 3, 2023
@miaulalala miaulalala merged commit 9e53934 into master May 10, 2023
@miaulalala miaulalala deleted the fix/caldav/invitation-outlook-compatibilty branch May 10, 2023 10:10
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention in the 27 changes issue

* @param string|null $contentType MIME Content-Type (e.g. text/plain or text/calendar)
*
* @return IMessage
* @since 26.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

27

* @return IMessage
* @since 26.0.0
*/
public function attachInline(string $body, string $name, string $contentType = null): IMessage;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?string $contentType = null

@DaphneMuller
Copy link

Hello!
Thank you for your work on this! I noticed that your PR still has the label 'documentation'. I'm not sure if you already had a look at the documentation for your PR, but at Nextcloud we strive to document changes that affect other app developers or other admins before the release takes place, and I'm pinging you with the hope to get this done.

Are you familiar with our documentation process already?
Changes that affect app developers should be documented here:
https://docs.nextcloud.com/server/27/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_27.html

Changes that affect administrators should be documented here:
https://docs.nextcloud.com/server/latest/admin_manual/release_notes/upgrade_to_27.html

While I understand sometimes it's handy to merge fast to get your changes in, it would be great if next time you could try to add the documentation before merging. You can find more information on that here:
https://docs.nextcloud.com/server/27/developer_manual/prologue/compatibility_app_ecosystem.html#documentation-procedures-of-changes-that-affect-app-developers

If all your documentation efforts are done, please remove the label 'documentation' and check the checkbox in your opening note and I'll stop bugging you :)

Many thanks in advance and thanks again for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar Invites - Outlook integration
6 participants