Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calendar emails to be outlook compatible - recreation of #12946 #34324

Closed
wants to merge 0 commits into from

Conversation

merlinwoff
Copy link

@merlinwoff merlinwoff commented Sep 29, 2022

Recreated the abandoned pull request #12946 in order to include review changes. Let's see if that works now ;)

Closes #12885

lib/private/Mail/Message.php Fixed Show resolved Hide resolved
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks

lib/private/Mail/Message.php Outdated Show resolved Hide resolved
lib/public/Mail/IMessage.php Outdated Show resolved Hide resolved
lib/private/Mail/Message.php Outdated Show resolved Hide resolved
lib/private/Mail/Message.php Outdated Show resolved Hide resolved
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (except for Christoph's comment), the RFC for iMIP explicitly allows this.

Thanks for taking care of this.

lib/private/Mail/Message.php Fixed Show resolved Hide resolved
@tcitworld tcitworld added this to the Nextcloud 26 milestone Sep 29, 2022
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 12, 2023
@ChristophWurst
Copy link
Member

The rebase and push broke the PR. Sorry about that.

@ChristophWurst
Copy link
Member

The rebase and push broke the PR. Sorry about that.

#36118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: caldav Related to CalDAV internals feature: dav integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar Invites - Outlook integration
4 participants