Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix share admin page #35399

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Fix share admin page #35399

merged 1 commit into from
Nov 24, 2022

Conversation

CarlSchwan
Copy link
Member

arrow function don't work that well with jquery

Fix #35301

@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Nov 24, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 26 milestone Nov 24, 2022
@CarlSchwan CarlSchwan requested a review from a team November 24, 2022 10:47
@CarlSchwan CarlSchwan self-assigned this Nov 24, 2022
@CarlSchwan CarlSchwan requested review from skjnldsv, Pytal and szaimen and removed request for a team November 24, 2022 10:47
@CarlSchwan
Copy link
Member Author

/backport stable25

@szaimen
Copy link
Contributor

szaimen commented Nov 24, 2022

/backport to stable25

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice find

Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of error arrow function are triggering ?

apps/settings/src/admin.js Outdated Show resolved Hide resolved
@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 24, 2022
@artonge
Copy link
Contributor

artonge commented Nov 24, 2022

What kind of error arrow function are triggering ?

Ah, this reference is changed... ok :)

arrow function don't work that well with jquery

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@szaimen
Copy link
Contributor

szaimen commented Nov 24, 2022

drone build was killed?

@blizzz
Copy link
Member

blizzz commented Nov 24, 2022

drone build at https://drone.nextcloud.com/nextcloud/server/26430

normally GH picks it up

@szaimen szaimen merged commit c11803e into master Nov 24, 2022
@szaimen szaimen deleted the fix/sharepi-admin branch November 24, 2022 17:47
@szaimen
Copy link
Contributor

szaimen commented Nov 24, 2022

/backport to stable25

@szaimen szaimen restored the fix/sharepi-admin branch November 24, 2022 21:06
@szaimen szaimen deleted the fix/sharepi-admin branch November 24, 2022 21:14
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

1 similar comment
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

@solracsf
Copy link
Member

solracsf commented Dec 8, 2022

This needs a 24 backport too.
Bug is present in 24.

@szaimen
Copy link
Contributor

szaimen commented Dec 8, 2022

/backport to stable24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Exclude groups from sharing broken
6 participants