Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Exclude groups from sharing broken #35301

Closed
5 of 9 tasks
schiessle opened this issue Nov 21, 2022 · 8 comments · Fixed by #35399
Closed
5 of 9 tasks

[Bug]: Exclude groups from sharing broken #35301

schiessle opened this issue Nov 21, 2022 · 8 comments · Fixed by #35399
Assignees
@CarlSchwan
Labels
2. developing Work in progress 25-feedback bug regression
Milestone
Nextcloud 24.0.8

Comments

@schiessle
Copy link
Member

schiessle commented Nov 21, 2022 •
edited
Loading

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • Nextcloud Server is running on 64bit capable CPU, PHP and OS.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

I can't exclude groups from sharing, the required input field in the admin settings is not shown

Steps to reproduce

  1. Go to the admin settings -> sharing
  2. check "Exclude Groups from sharing"

Nothing happens:

grafik

Tested with Nexcloud 25.0.1 and Nextcloud 24.0.7

After the checkbox is checked and I reload the page the input field is there. It seems like "just" the live switch is broken when I check the checkbox

Expected behavior

A input field show up where I can select the groups I want to exclude:

grafik

Installation method

No response

Operating system

No response

PHP engine version

No response

Web server

No response

Database engine version

No response

Is this bug present after an update or on a fresh install?

No response

Are you using the Nextcloud Server Encryption module?

No response

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

-

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response
@schiessle schiessle added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Nov 21, 2022
@PVince81
Copy link
Member

I fixed something similar recently on master, a jquery selector was missing.

will recheck to see if that one field is affected as well

@PVince81 PVince81 self-assigned this Nov 23, 2022
@PVince81 PVince81 added this to the Nextcloud 24.0.8 milestone Nov 23, 2022
@PVince81 PVince81 added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Nov 23, 2022
@PVince81
Copy link
Member

confirmed on stable25

PVince81 referenced this issue Nov 23, 2022
@CarlSchwan
Cleanup admin settings js files
7c8a901 
* Move admin.js to webpack, so that this use the bundled jquery files
  instead of the deprecated window.$ Also fixing formatting

* Remove log.js that seems to be from a time where logreader was bundled
  with server and I couldn't find an usage of it anymore

* Fix recent regression in rebuild navigation function (now not depending on
  jquery anymore and bundled by webpack).

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@PVince81
Copy link
Member

it looks like all the checkboxes which have a toggle "hidden" seem to be broken
some only work once when clicking then not again

seems the regression is caused by 7c8a901

@CarlSchwan can you have a look and make sure that all toggles are working ?

@PVince81 PVince81 removed their assignment Nov 23, 2022
@CarlSchwan
Copy link
Member

I'm trying to debug this and fun things is that the bug only happen when building in production mode with npm run build but not in debug mode

@PVince81
Copy link
Member

a lot of those visibility management are done with jquery though, not sure why webpack and co would affect it

@CarlSchwan
Copy link
Member

Yeah and I tried to rewrite it in vanilla js and I got the same result. Work on dev mode breaks in production mode

@CarlSchwan
Copy link
Member

Looks like the onChange event is not triggered correctly

document.getElementById('shareapiExcludeGroups').onclick = () => console.error("clicked") 
document.getElementById('shareapiExcludeGroups').onChange = () => console.error("changed")

Only clicked is displayed when clicking on the checkbox, problem is that clicked is not working for keyboard navigation

@CarlSchwan
Copy link
Member

I found the issue, patch will arrive soon

@CarlSchwan CarlSchwan mentioned this issue Nov 24, 2022
Merged
@szaimen szaimen added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CarlSchwan CarlSchwan

Labels
2. developing Work in progress 25-feedback bug regression
Projects
None yet
Milestone
Nextcloud 24.0.8
Development

Successfully merging a pull request may close this issue.

Fix share admin page nextcloud/server
4 participants
@PVince81 @schiessle @CarlSchwan @szaimen