Do not check quota for non Node #35398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louis Chemineau <louis@chmn.me>
|
/backport to stable25 |
|
/backport to stable24 |
|
/backport to stable23 |
PVince81
added
4. to release
artonge
deleted the
artonge/fix/dont_error_when_destination_is_not_a_node
branch
This was referenced Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #35009, the copy of elements that are not
Nodewill fail.This PR considers that non
Nodeobjects are not subject to quota limitation, and therefore should not be blocked.It would be ok to limit the change to the
parentNodeonly.