Check quota on file copy #35009
Merged
Check quota on file copy #35009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable25 |
|
/backport to stable24 |
|
/backport to stable23 |
come-nc
requested review from
PVince81,
GretaD,
a team,
ArtificialOwl and
skjnldsv
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
GretaD
approved these changes
Nov 7, 2022
|
psalm not happy and an integration test fails now due to beforeCopy and a dot file that is not allowed. I suspect that the latter is more about a test case doing something dodgy than a bug |
|
Seems like https://drone.nextcloud.com/nextcloud/server/25500/20/3 fails. Not sure if related though... |
{
"Exception": "OCA\\DAV\\Connector\\Sabre\\Exception\\InvalidPath",
"Message": "Dot files are not allowed",
"Code": 0,
"Trace": [
{
"file": "/drone/src/apps/dav/lib/Connector/Sabre/QuotaPlugin.php",
"line": 158,
"function": "getNodeForPath",
"class": "OCA\\DAV\\Connector\\Sabre\\ObjectTree",
"type": "->"
},
{
"file": "/drone/src/3rdparty/sabre/event/lib/WildcardEmitterTrait.php",
"line": 89,
"function": "beforeCopy",
"class": "OCA\\DAV\\Connector\\Sabre\\QuotaPlugin",
"type": "->"
},
{
"file": "/drone/src/3rdparty/sabre/dav/lib/DAV/CorePlugin.php",
"line": 648,
"function": "emit",
"class": "Sabre\\DAV\\Server",
"type": "->"
},
{
"file": "/drone/src/3rdparty/sabre/event/lib/WildcardEmitterTrait.php",
"line": 89,
"function": "httpCopy",
"class": "Sabre\\DAV\\CorePlugin",
"type": "->"
},
{
"file": "/drone/src/3rdparty/sabre/dav/lib/DAV/Server.php",
"line": 472,
"function": "emit",
"class": "Sabre\\DAV\\Server",
"type": "->"
},
{
"file": "/drone/src/3rdparty/sabre/dav/lib/DAV/Server.php",
"line": 253,
"function": "invokeMethod",
"class": "Sabre\\DAV\\Server",
"type": "->"
},
{
"file": "/drone/src/3rdparty/sabre/dav/lib/DAV/Server.php",
"line": 321,
"function": "start",
"class": "Sabre\\DAV\\Server",
"type": "->"
},
{
"file": "/drone/src/apps/dav/appinfo/v1/webdav.php",
"line": 85,
"function": "exec",
"class": "Sabre\\DAV\\Server",
"type": "->"
},
{
"file": "/drone/src/remote.php",
"line": 171,
"args": [
"/drone/src/apps/dav/appinfo/v1/webdav.php"
],
"function": "require_once"
}
],
"File": "/drone/src/apps/dav/lib/Connector/Sabre/ObjectTree.php",
"Line": 124,
"message": "Dot files are not allowed",
"exception": {},
"CustomMessage": "Dot files are not allowed"
}Sounds very related |
|
|
Nice catch, thank you. Then the same change is needed in beforeMove, no? |
| $parent = ''; | ||
| } | ||
| $parentNode = $this->server->tree->getNodeForPath($parent); | ||
| $path = $parentNode->getPath(); |
Check notice
Code scanning / Psalm
UndefinedInterfaceMethod
|
/rebase |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Let’s be safe Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
nextcloud-command
force-pushed
the
fix/check-quota-on-copy
branch
from
3fadfc6
to
feafa63
Compare
PVince81
added
the
4. to release
|
/backport to stable24 |
|
/backport to stable23 |
|
The backport to stable24 failed. Please do this backport manually. |
|
The backport to stable23 failed. Please do this backport manually. |
This was referenced Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34975
Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com