Accessible names for share panel buttons #33316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
requested review from
jancborchardt,
JuliaKirschenheuter,
CarlSchwan and
Pytal
|
I never hit the node compilation jackpot |
|
/compile amend / |
nextcloud-command
force-pushed
the
bugfix/noid/aria-label-share-link-buttons
branch
from
425eb4a to
d8e9eef
Compare
Pytal
approved these changes
Jul 22, 2022
PVince81
force-pushed
the
bugfix/noid/aria-label-share-link-buttons
branch
from
d8e9eef to
39e4b40
Compare
artonge
approved these changes
Jul 26, 2022
PVince81
force-pushed
the
bugfix/noid/aria-label-share-link-buttons
branch
from
39e4b40 to
c81a3d4
Compare
PVince81
added
4. to release
|
/compile amend / |
nextcloud-command
force-pushed
the
bugfix/noid/aria-label-share-link-buttons
branch
from
c81a3d4 to
cda969d
Compare
Added aria-label for the buttons on the share panel. Signed-off-by: Vincent Petry <vincent@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
PVince81
force-pushed
the
bugfix/noid/aria-label-share-link-buttons
branch
from
cda969d to
4a8cbb8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added aria-label for the buttons on the share panel.
It was reported by Lighthouse in snapshot mode.
Note: an "aria-describedby" appears when tabbing on the button but it's not enough to satisfy the scanner, mostly because one can retrieve a list of all links on a page and those buttons would have no name at all.