Skip to content

Commit

Permalink
Merge pull request #33316 from nextcloud/bugfix/noid/aria-label-share…
Browse files Browse the repository at this point in the history
…-link-buttons

Accessible names for share panel buttons
  • Loading branch information
PVince81 authored Jul 27, 2022
2 parents fc276ba + 4a8cbb8 commit 3e9c52a
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 4 deletions.
1 change: 1 addition & 0 deletions apps/files_sharing/src/components/SharingEntryInternal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

<ActionLink ref="copyButton"
:href="internalLink"
:aria-label="t('files_sharing', 'Copy internal link to clipboard')"
target="_blank"
:icon="copied && copySuccess ? 'icon-checkmark-color' : 'icon-clippy'"
@click.prevent="copyLink">
Expand Down
1 change: 1 addition & 0 deletions apps/files_sharing/src/components/SharingEntryLink.vue
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
class="sharing-entry__copy">
<ActionLink :href="shareLink"
target="_blank"
:aria-label="t('files_sharing', 'Copy public link to clipboard')"
:icon="copied && copySuccess ? 'icon-checkmark-color' : 'icon-clippy'"
@click.stop.prevent="copyLink">
{{ clipboardTooltip }}
Expand Down
4 changes: 3 additions & 1 deletion apps/files_sharing/src/views/SharingInherited.vue
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@
<template #avatar>
<div class="avatar-shared icon-more-white" />
</template>
<ActionButton :icon="showInheritedSharesIcon" @click.prevent.stop="toggleInheritedShares">
<ActionButton :icon="showInheritedSharesIcon"
:aria-label="mainTitle"
@click.prevent.stop="toggleInheritedShares">
{{ toggleTooltip }}
</ActionButton>
</SharingEntrySimple>
Expand Down
4 changes: 2 additions & 2 deletions dist/files_sharing-files_sharing_tab.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/files_sharing-files_sharing_tab.js.map

Large diffs are not rendered by default.

0 comments on commit 3e9c52a

Please sign in to comment.