[files app]: Fix dark color mode detection for filelist #33299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
design
szaimen
requested review from
skjnldsv,
a team,
PVince81 and
szaimen
and removed request for
a team
Pytal
reviewed
Jul 22, 2022
susnux
force-pushed
the
fix/files-dark-color-theme
branch
from
1bec397 to
7573cf3
Compare
artonge
reviewed
Jul 25, 2022
Pytal
reviewed
Jul 25, 2022
When system default color theme is selected for theming, the `enabledThemes` array is empty or just contains on entry `'default'`, in this case the color theme has to be retrieved from the browser to ensure text like the modified date is readable. This fixes #33298 Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
susnux
force-pushed
the
fix/files-dark-color-theme
branch
from
7573cf3 to
e4c825e
Compare
artonge
approved these changes
Jul 26, 2022
Pytal
approved these changes
Jul 26, 2022
|
CI failure unrelated |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The color of the file list entries is dynamically calculated, but clipped to readable values.
This clipping is currently broken when using the system color theme and the system is using a dark color theme.
When system default color theme is selected for theming, the
enabledThemesarrayis empty or just contains one entry
'default', in this case the color theme hasto be retrieved from the browser to ensure text like the modified date is readable.
Before:
After:
