Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: files app does not detect dark color mode if using system theming is enabled #33298

Closed
5 of 9 tasks
susnux opened this issue Jul 20, 2022 · 0 comments · Fixed by #33299
Closed
5 of 9 tasks

[Bug]: files app does not detect dark color mode if using system theming is enabled #33298

susnux opened this issue Jul 20, 2022 · 0 comments · Fixed by #33299
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug design Design, UI, UX, etc. feature: files

Comments

@susnux
Copy link
Contributor

susnux commented Jul 20, 2022

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • Nextcloud Server is running on 64bit capable CPU, PHP and OS.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

On current master (did not test NC24, NC23 works) the files app does not correctly detects the dark color mode if system theme is selected for theming.

So the text is hardly readable, reading the date is quite impossible (black text on dark background), see this example:
file list with dark color mode is not readable

Steps to reproduce

  1. Open NC at current master
  2. Open the file list
  3. Set browser to dark color mode

Expected behavior

App uses readable color for text

Installation method

Other

Operating system

No response

PHP engine version

No response

Web server

No response

Database engine version

No response

Is this bug present after an update or on a fresh install?

No response

Are you using the Nextcloud Server Encryption module?

No response

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

Nothing more than the default apps

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response
@susnux susnux added bug design Design, UI, UX, etc. 0. Needs triage Pending check for reproducibility or if it fits our roadmap feature: files labels Jul 20, 2022
susnux added a commit that referenced this issue Jul 20, 2022
@susnux
files: Fix colormode detection for filelist
1bec397 
When system default color theme is selected for theming, the `enabledThemes` array
is empty or just contains on entry `'default'`, in this case the color theme has
to be retrieved from the browser to ensure text like the modified date is readable.

This fixes #33298

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
@susnux susnux mentioned this issue Jul 20, 2022
Merged
@susnux susnux changed the title [Bug]: [Bug]: files app does not detect dark color mode if using system theming is enabled Jul 20, 2022
susnux added a commit that referenced this issue Jul 24, 2022
@susnux
files: Fix colormode detection for filelist
7573cf3 
When system default color theme is selected for theming, the `enabledThemes` array
is empty or just contains on entry `'default'`, in this case the color theme has
to be retrieved from the browser to ensure text like the modified date is readable.

This fixes #33298

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
susnux added a commit that referenced this issue Jul 26, 2022
@susnux
files: Fix colormode detection for filelist
e4c825e 
When system default color theme is selected for theming, the `enabledThemes` array
is empty or just contains on entry `'default'`, in this case the color theme has
to be retrieved from the browser to ensure text like the modified date is readable.

This fixes #33298

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug design Design, UI, UX, etc. feature: files
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[files app]: Fix dark color mode detection for filelist nextcloud/server
1 participant
@susnux