Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix size of template picker #31916

Merged
merged 1 commit into from
Apr 11, 2022
Merged

fix size of template picker #31916

merged 1 commit into from
Apr 11, 2022

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Apr 9, 2022

Signed-off-by: szaimen szaimen@e.mail.de

Before After
image image
image image
For my own testing
docker run -it \
-e SERVER_BRANCH=enh/noid/template-picker-size \
-e TEXT_BRANCH=master \
-e VIEWER_BRANCH=master \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.128 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Apr 9, 2022
@szaimen szaimen added this to the Nextcloud 24 milestone Apr 9, 2022
@szaimen szaimen requested review from juliushaertl, skjnldsv, a team, PVince81 and vanpertsch and removed request for a team April 9, 2022 11:07
@szaimen
Copy link
Contributor Author

szaimen commented Apr 9, 2022

/compile amend /

Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv
Copy link
Member

skjnldsv commented Apr 9, 2022

Screenshots?

@szaimen
Copy link
Contributor Author

szaimen commented Apr 10, 2022

Screenshots?

Is this really needed here?

@skjnldsv
Copy link
Member

Screenshots?

Is this really needed here?

Helps approving without setting this up.
Especially because you removed height: fit-content;. needs to be tested with 1, 5 or 15 templates files so we know how it looks 😛

Helps get PR in faster 😉
I think any design change should have screenshots, it helps 🤷

@szaimen
Copy link
Contributor Author

szaimen commented Apr 11, 2022

Screenshots?

Is this really needed here?

Helps approving without setting this up. Especially because you removed height: fit-content;. needs to be tested with 1, 5 or 15 templates files so we know how it looks 😛

Helps get PR in faster 😉 I think any design change should have screenshots, it helps 🤷

Fine by me. Will add screenshots later :)

@szaimen
Copy link
Contributor Author

szaimen commented Apr 11, 2022

Helps approving without setting this up.

Btw: not sure if you've seen this but there is a one-liner available that sets this up easily ;)

docker run -it \
-e SERVER_BRANCH=enh/noid/template-picker-size \
-e TEXT_BRANCH=master \
-e VIEWER_BRANCH=master \
-p 127.0.0.1:8443:443 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen
Copy link
Contributor Author

szaimen commented Apr 11, 2022

Fine by me. Will add screenshots later :)

done

@artonge
Copy link
Contributor

artonge commented Apr 11, 2022

What's the motivation behind this change?

@szaimen
Copy link
Contributor Author

szaimen commented Apr 11, 2022

What's the motivation behind this change?

It was wrongly changed during the upgrade to vue 5.0 from my side...

@szaimen szaimen merged commit 2538419 into master Apr 11, 2022
@szaimen szaimen deleted the enh/noid/template-picker-size branch April 11, 2022 19:10
@blizzz blizzz mentioned this pull request Apr 13, 2022
@juliushaertl
Copy link
Member

/backport to stable24

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants