NMC-533 Set new folder name inline: rebased

[skjnldsv]

Rebased version of #28645

Closes #28645

[szaimen]

tested and seems to work well 👍
(didn't review the code though)

[skjnldsv]

Acceptance needs to be updated

[skjnldsv]

/rebase

[skjnldsv]

@danxuliu can yuo help with the acceptance tests please?

[danxuliu]

@danxuliu can yuo help with the acceptance tests please?

I would love to, but unless I find a time-turner somewhere it is unlikely that I will be able to do it this week, sorry.

[danxuliu]

Looks like one scenario is still failing:

Although that scenario is failing that one is not the real failure ;-) In errors like those the acceptance tests try the action again, as you can see from the following line to the ones in the screenshot (Trying again). As there is not another error immediately after trying again the action succeeded and the test continued.

The real failure is in the last step:

And I see that the file list contains a file named "Subsubfolder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file Subsubfolder in file list could not be found after 100 seconds (NoSuchElementException)

The test passes locally, so it looks like a hiccup. I would like to understand why it failed to harden the test, but unfortunately I can not see how it could have happened :-(

Independently of all that, if the last commit does not touch JavaScript files please do not amend it to add the compiled files and add an independent commit instead.

[szaimen]

Independently of all that, if the last commit does not touch JavaScript files please do not amend it to add the compiled files and add an independent commit instead.

Sorry for that. Shall I do this now or is it fine for now?

[szaimen]

The test passes locally, so it looks like a hiccup. I would like to understand why it failed to harden the test, but unfortunately I can not see how it could have happened :-(

do we wanna try to restart drone or hope that it was only a hiccup?

[danxuliu]

Independently of all that, if the last commit does not touch JavaScript files please do not amend it to add the compiled files and add an independent commit instead.

Sorry for that. Shall I do this now or is it fine for now?

No problem at all :-) I have split the commit in two, it is fine 👍

The test passes locally, so it looks like a hiccup. I would like to understand why it failed to harden the test, but unfortunately I can not see how it could have happened :-(

do we wanna try to restart drone or hope that it was only a hiccup?

As I have force pushed to split the commit (twice, because the first time I used the wrong commit author 🤦) Drone will run again (I have already stopped the first run corresponding to the commit with the wrong author). So let's see ;-)

[szaimen]

Great, thanks! :)

[szaimen]

It seems to fail again...

[danxuliu]

It seems to fail again...

It is just another hiccup 🤷 And it did not fail in the same step, but on a previous one (looking for Subfolder rather than for Subsubfolder). Hopefully I will be able to find out what is going on at some point...

In any case, from the point of view of the acceptance tests, the pull request could be merged despite the failure.

[szaimen]

In any case, from the point of view of the acceptance tests, the pull request could be merged despite the failure.

Okay 👍

I'll leave that to @skjnldsv :)

[szaimen]

is this readdy to merge?

[szaimen]

@skjnldsv what would you say: is it worth to still get this in before the vue rewrite or should we skip this to not run into additional conflicts later on?