Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance dav PROPFIND #31843

Merged
merged 4 commits into from
Apr 6, 2022
Merged

Improve performance dav PROPFIND #31843

merged 4 commits into from
Apr 6, 2022

Conversation

icewind1991
Copy link
Member

  • Allow reusing known folder info when getting directory content
  • Reuse known fileinfo to get the filesystem node for each dav node
  • Use known filesystem node from above in SharesPlugin instead of re-querying

Saves 4 queries for each propfind in my testing

@icewind1991 icewind1991 added this to the Nextcloud 24 milestone Apr 5, 2022
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, skjnldsv and come-nc and removed request for a team April 5, 2022 13:40
apps/dav/lib/Connector/Sabre/Node.php Outdated Show resolved Hide resolved
lib/private/Files/View.php Show resolved Hide resolved
lib/private/Files/View.php Outdated Show resolved Hide resolved
@skjnldsv
Copy link
Member

skjnldsv commented Apr 6, 2022

Needs a rebase and we're good! 🚀

@icewind1991 icewind1991 force-pushed the dav-plugin-perf branch 2 times, most recently from 86dcd4f to f8a00c7 Compare April 6, 2022 12:08
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants