Identical query when getting directory listing of a Folder

[rullzer]

When you get a folder from the Node API and then at some point on that folder run getDirectoryListing it will perform the same query.

This is caused at https://github.com/nextcloud/server/blob/master/lib/private/Files/Node/Folder.php#L96 because we pass in the path (and not the folder object) and so https://github.com/nextcloud/server/blob/master/lib/private/Files/View.php#L1404 will perform the exact same query.

Now the query is most likely fast. But it is still silly to do it twice (especially since in a lot of cases they will happen right after each other).

@icewind1991 please have a look once 12 is out 😉

[szaimen]

I suppose this issue is still valid? If not, please close this issue!

[joshtrichards]

I believe this was addressed, probably by #33602 and a bit by #31843, but this isn't an area of the code where I'm at all comfortable saying with certainty on my own. Can one of you confirm this is closed by those prior PRs/merges?