Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable16] Fix occ maintenance:install database connect failure #19328

Merged
merged 5 commits into from
Apr 14, 2020
Merged

[stable16] Fix occ maintenance:install database connect failure #19328

merged 5 commits into from
Apr 14, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #19303

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 16.0.10 milestone Feb 6, 2020
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 6, 2020
Merged
nickvergessen
nickvergessen requested changes Feb 6, 2020
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking merge as per above comments

@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Mar 6, 2020
@skjnldsv
Copy link
Member

skjnldsv commented Mar 6, 2020

Nice, this will motivate people to upgrade :p

@nickvergessen nickvergessen mentioned this pull request Apr 2, 2020
Merged
@rullzer rullzer mentioned this pull request Apr 13, 2020
Merged
3 tasks
@georgehrke georgehrke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 14, 2020
@nickvergessen @skjnldsv
Only provide the auth method for MySQL 8.0+ to not break MariaDB
07e7f79 
Provide the auth method for MySQL 8.0+

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @skjnldsv
Check the new connection on setup like with PostgreSQL and Oracle
b48daab 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @skjnldsv
Split the exception handling so install errors don't log as setup errors
6e892c0 
More gebuging

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @skjnldsv
Correctly append the port to the host so it's written to the config c…
6cdc63f 
…orrectly

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @skjnldsv
Do not allow installing on MySQL 8.0+ and MariaDB 10.4+
f36ba8b 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@skjnldsv skjnldsv force-pushed the backport/19303/stable16 branch from 05e15d8 to f36ba8b Compare April 14, 2020 09:02
@blizzz blizzz merged commit 8e06711 into stable16 Apr 14, 2020
@blizzz blizzz deleted the backport/19303/stable16 branch April 14, 2020 11:08
@Grotax Grotax mentioned this pull request Apr 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@georgehrke georgehrke georgehrke approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@kesselb kesselb Awaiting requested review from kesselb

@MichaIng MichaIng Awaiting requested review from MichaIng

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: install and update
Projects
None yet
Milestone
Nextcloud 16.0.10
Development

Successfully merging this pull request may close these issues.
6 participants
@skjnldsv @nickvergessen @georgehrke @ChristophWurst @blizzz @MichaIng