Nc19 #627
Merged
Nc19 #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Grotax still developing? |
|
I would pick this up again, just didn't have the time |
|
@SMillerDev the new annoying thing that popped up is that mariadb 10.4 is no longer supported by the latest nc 16 release coming out soon. People that have installed it will be fine just our installation in the vm will fail nextcloud/server#19328 (comment) There is no official way to test multiple db version though travis-ci/travis-ci#954 (comment) And I don't feel like adding another level of complexity to the tests. So we either downgrade to 10.3 for all or we drop nc16 from our tests with mariadb. |
SMillerDev
reviewed
Apr 22, 2020
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
SMillerDev
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making new ready for Nextcloud 19
#18479