Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set file search by certain number of characters in config.php #12143

Closed
wants to merge 2 commits into from
Closed

Set file search by certain number of characters in config.php #12143

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 30, 2018

solution for issue #12139

Solves the problem when you want to search in folder with thousands of files and the search freezes.

@MorrisJobke
Copy link
Member

My arguments from #12065 (comment) are still valid here.

Input from @nextcloud/designers is very welcome.

@MorrisJobke
Copy link
Member

@Studna95 Don't get me wrong: I really like that you contribute something 👍 I just want to have it fixed properly, because in this way it is basically only fixed for you and for nobody else, because nobody else will configure this special item. So I would love to go one step back and check what the actual problem is. In the meantime you can use your fix on your machine and work around the problems you described until we have a real solution to the problem.

@jancborchardt
Copy link
Member

Same here. As I said in #12139 (comment)

Agree with @MorrisJobke – this is a technical issue which needs to be properly fixed. A configuration option makes no sense here since then everyone would have to fix it for themselves. ;)

@jancborchardt
Copy link
Member

So how do we continue here? @rullzer @MorrisJobke we don’t want to add a setting, so we have to reject the pull request in its current form. @Studna95 sorry again about this – maybe we come up with a better solution?

@skjnldsv
Copy link
Member

I would suggest closing and directly fix the files list implementation

@jancborchardt
Copy link
Member

@skjnldsv sounds good! If you have further pointers for @Studna95 if they want to work on that, let them know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants