Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching among thousands of files freezes and web browser crashes #12139

Closed
ghost opened this issue Oct 30, 2018 · 8 comments
Closed

Searching among thousands of files freezes and web browser crashes #12139

ghost opened this issue Oct 30, 2018 · 8 comments
Labels

Comments

@ghost
Copy link

ghost commented Oct 30, 2018

Steps to reproduce

  1. Search in folder with thousands of files

Expected behaviour

Search works and you are able to find what you are looking for

Actual behaviour

Search freezes and the browser crashes

Server configuration

<?php
$CONFIG = array (
  'passwordsalt' => '*',
  'secret' => '*',
  'trusted_domains' => 
  array (
    0 => '*',
  ),
  'datadirectory' => '/var/www/nextcloud-2/data',
  'overwrite.cli.url' => '*',
  'dbtype' => 'mysql',
  'version' => '14.0.0.19',
  'installed' => true,
  'dbname' => 'nxdb2',
  'dbhost' => 'localhost',
  'dbport' => '',
  'dbtableprefix' => 'oc_',
  'dbuser' => 'nxdb2',
  'dbpassword' => '*',
  'instanceid' => 'AAAAAAAAAAAAAAAAAAAAAA',
  'objectstore' => 
  array (
    'class' => 'OC\\Files\\ObjectStore\\S3',
    'arguments' => 
    array (
      'bucket' => '*',
      'autocreate' => true,
      'key' => '*',
      'secret' => '*',
      'hostname' => '*',
      'port' => 443,
      'use_ssl' => true,
      'region' => 'optional',
      'use_path_style' => true,
      'forcessl' => true,
      'overwriteprotocol' => 'https',
    ),
  ),
  'updater.release.channel' => 'beta',
  'maintenance' => false,
  'theme' => '',
  'loglevel' => 2,
);

Operating system:
server Debian 9, client win10

Web server:
Apache 2.4.5
NX 14 / 13 (related too)

Database:
mysql

PHP version:
PHP 7.0.27-0+deb9u1 (cli) (built: Jan 5 2018 13:51:52) ( NTS )

Nextcloud version: (see Nextcloud admin page)
14.0.0.19

Updated from an older Nextcloud/ownCloud or fresh install:
Fresh install

Where did you install Nextcloud from:
Github

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #3271 (inefficient file search), #9925 (Select only searched files), #10711 (Upload Problem on Web Browsers), #12041 (Properly hide files when searching), and #8200 (some browser can't download files!).

@MorrisJobke
Copy link
Member

Search freezes and the browser crashes

Do you by any chance know why it freezes? Are there too many elements on the page? Is the response never returning?

IMO we should address the root cause (why it freezes) and not hide it behind yet another config option (as proposed in #12143).

See also my arguments in #12065 (comment)

cc @nextcloud/designers for some input here

@skjnldsv @danxuliu for the performance problems here.

@MorrisJobke MorrisJobke changed the title Searching among thousands of files freezes and web browser crashes #bug Searching among thousands of files freezes and web browser crashes Oct 30, 2018
@skjnldsv
Copy link
Member

Do you by any chance know why it freezes? Are there too many elements on the page? Is the response never returning?

My guess.
The filtering we use is pretty bad performance wise :(

@ghost
Copy link
Author

ghost commented Oct 30, 2018

Do you by any chance know why it freezes? Are there too many elements on the page? Is the response never returning?

Honestly, no idea. The searching just takes too long time or it just freezes and crash.

IMO we should address the root cause (why it freezes) and not hide it behind yet another config option (as proposed in #12143).

Indeed. But this could be temporarily solution until it is properly fixed. IMO this solution is quite simple and you can use it if you want.

Also, in corporate systems it is usual that you can seach by certain number of chars.

@jancborchardt
Copy link
Member

Agree with @MorrisJobke – this is a technical issue which needs to be properly fixed. A configuration option makes no sense here since then everyone would have to fix it for themselves. ;)

@MorrisJobke
Copy link
Member

Indeed. But this could be temporarily solution until it is properly fixed. IMO this solution is quite simple and you can use it if you want.

That's why I said, that you can use it in your system just fine, but we will not merge it into our product because then we need to maintain if for ever. People use it then and complain that we take "features" from them. Just to let you know why we act in that way.

@MorrisJobke
Copy link
Member

I just found this issue here: #6861

@MorrisJobke
Copy link
Member

Duplicate of #6861

@MorrisJobke MorrisJobke marked this as a duplicate of #6861 Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants