[stable25] fix(settings): browser freeze when picking photos directory #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
approved these changes
Sep 25, 2023
|
/compile amend / |
nextcloud-command
force-pushed
the
fix/settings/folder-picker-freeze
branch
from
9da49ad
to
1574c3a
Compare
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
fix/settings/folder-picker-freeze
branch
from
e94909c
to
9211bd2
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
fix/settings/folder-picker-freeze
branch
from
1d79389
to
15be988
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a browser freeze caused by nextcloud/nextcloud-focus-trap#2.
Changes by this PR to make it work:
import '@nextcloud/dialogs/dist/index.css'/) to prevent weird file picker behavior (due to a potentially missing/Photosfolder). Note: The old picker automatically switched to the root directory if the initial directory does not exist. The new one just loads forever.