Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

@nextcloud/focus-trap usage cause infinite recursion #2

Open
artonge opened this issue Oct 19, 2022 · 6 comments
Open

@nextcloud/focus-trap usage cause infinite recursion #2

artonge opened this issue Oct 19, 2022 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@artonge
Copy link

artonge commented Oct 19, 2022

I have this error on Photos when opening any modals since the upgrade to v7.0.1:

Screenshot from 2022-10-19 17-02-28

This makes modal opening very laggy.

cc @vinicius73 and @skjnldsv

nextcloud-libraries/nextcloud-vue#3347

@artonge artonge added the bug Something isn't working label Oct 19, 2022
@vinicius73
Copy link
Member

This error is the same in the previous versions.

We are waiting for viewer app upgrade to the new version of nextcloud components.

nextcloud/viewer#1429

@skjnldsv skjnldsv reopened this Oct 19, 2022
@skjnldsv skjnldsv transferred this issue from nextcloud-libraries/nextcloud-vue Oct 19, 2022
@skjnldsv
Copy link
Member

skjnldsv commented Oct 19, 2022

The activate is looping
Somehow real is not the right var here @vinicius73

Peek.19-10-2022.17-54.mp4

@skjnldsv
Copy link
Member

skjnldsv commented Oct 19, 2022

Btw the original lib already have a queue system, which I did not assumed
https://github.com/focus-trap/focus-trap/blob/65be07c4b3c371c47444edf77aecbf947a55587d/index.js#L3-L35

Another option would be to ovver a contribution there to allow registering the list as a global variable 👍

@vinicius73
Copy link
Member

@PVince81
Copy link
Member

PVince81 commented Nov 4, 2022

new one: focus-trap/focus-trap#826

@PVince81
Copy link
Member

PVince81 commented Nov 15, 2022

upstream PR was merged and released

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants