Downgrade to @nc/vue v7.0.0 #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louis Chemineau <louis@chmn.me>
|
Hum, that seems like the other way around ? |
|
What do you mean ? That v7.0.1 should contain a fix ? Not in my testing. |
I mean, which modal are we opening? |
|
When creating an album or adding collaborators |
Ah, sorry, the issue you're referencing was about Viewer, got confused. :) |
|
Approve then ? :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focus traps cause an infinite recursion, which make opening any modal laggy, this also cause e2e tests to fail.
Downgrade until a proper solution is found.
nextcloud/nextcloud-focus-trap#2