Trigger a proper event-bus event #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only listened to in https://github.com/nextcloud/server/blob/d5e854e7efda5572682988faeef500e6f71a7b57/apps/files/js/filelist.js#L380-L384 and https://github.com/nextcloud/server/blob/ab2b3d2755e0b1d54bac84f842426b0b8d3aa006/apps/federatedfilesharing/js/external.js#L86-L91 But that code is not transpiled so I'm not sure how to use the |
skjnldsv
reviewed
Sep 2, 2020
This was referenced Sep 3, 2020
2 tasks
|
@nickvergessen do we still want to add this? |
|
Yes, so we can get rid of jQuery in this app |
🚀! Anything blocking other than the comments above? |
|
The most important bit would be to adjust the listeners as outlined above. That is the part I failed to do. |
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
This was referenced Sep 20, 2022
Closed
Should e.g. allow Talk to go to the chat without a page reload and trigger message loading already Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/noid/proper-event-bus
branch
from
43be609
to
c2385d9
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
requested review from
juliushaertl,
marcoambrosini and
Antreesy
Merged
5 tasks
Antreesy
approved these changes
Feb 7, 2023
This was referenced Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per nextcloud-libraries/nextcloud-event-bus#131