Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen to notifications for success or failure of export/import #125

Open
2 tasks done
Pytal opened this issue Apr 21, 2022 · 3 comments
Open
2 tasks done

Listen to notifications for success or failure of export/import #125

Pytal opened this issue Apr 21, 2022 · 3 comments
Assignees
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature request
Milestone

Comments

@Pytal
Copy link
Member

Pytal commented Apr 21, 2022

The success or failure state of exports and imports should be derived by listening to notifications (if the app is enabled) instead of the status endpoint so that the modal and notifications on the frontend do not present discrepancies or desync due to different polling intervals

  1. The status endpoint would only be queried to check if the export/import was queued successfully and if the job has started
  2. Final success/failure state of the job would be derived by listening to notifications through the event-bus to
    a) ensure a single source of truth is used for both the modal and notifications
    b) provide actual success/failure state rather than just if the job has finished executing as the user_export_jobs and user_import_jobs tables do not contain this information

Requires

@Pytal Pytal added 1. to develop Accepted and waiting to be taken care of enhancement New feature request labels Apr 21, 2022
@Pytal Pytal added this to the 1.1 milestone Apr 21, 2022
@Pytal Pytal self-assigned this Apr 21, 2022
@nickvergessen
Copy link
Member

Just for the record:
nextcloud/notifications#728 is only triggered when the user clicks an action of a notification and your notifications in https://github.com/nextcloud/user_migration/blob/main/lib/Notification/Notifier.php don't have any actions.

There is currently no event for when a new notification came in, but I guess we can add this on top of nextcloud/notifications#728 so once the event-bus is in

@Pytal Pytal modified the milestones: 1.1, 1.2 Jul 22, 2022
@come-nc come-nc modified the milestones: 1.2, 1.3 Sep 29, 2022
@Pytal Pytal modified the milestones: 3.0, 4.0 Mar 30, 2023
@Pytal
Copy link
Member Author

Pytal commented Apr 1, 2023

For reference, tracking #385 (comment) here @come-nc

@nickvergessen
Copy link
Member

There is now an event for when a notification came in btw

@come-nc come-nc modified the milestones: 4.0, 5.0 May 16, 2023
@Pytal Pytal modified the milestones: 5.0, 6.0 Dec 1, 2023
@Pytal Pytal modified the milestones: 6.0, 8.0 Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature request
Projects
None yet
Development

No branches or pull requests

3 participants