Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[28] restore acl ui in sharing tab #2746

Merged
merged 7 commits into from
Jan 12, 2024
Merged

[28] restore acl ui in sharing tab #2746

merged 7 commits into from
Jan 12, 2024

Conversation

icewind1991
Copy link
Member

Backport of #2736

@icewind1991
restore acl ui in sharing tab
448be5d 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
update dependencies to fix vue warnings
074e0de 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix acl radio buttons
d0a4013 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix acl inheritance indicator
f555302 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
update components
5d74370 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
move acl user/group select to NcSelect
26e0e28 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
format code
b8b4b78 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Items that need to be reviewed label Jan 11, 2024
@icewind1991 icewind1991 added this to the Nextcloud 28 milestone Jan 11, 2024
Antreesy
Antreesy approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tested, opening and working in general
Maybe it requires some thorough check due to bumping that much libraries in once (checked nc/vue, changes seem ok between 7.12.6 => 8.4.0)

@icewind1991 icewind1991 merged commit e1d5768 into stable28 Jan 12, 2024
23 checks passed
@icewind1991 icewind1991 deleted the restore-acl-ui-28 branch January 12, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@come-nc come-nc Awaiting requested review from come-nc

Assignees
No one assigned
Labels
3. to review Items that need to be reviewed
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
2 participants
@icewind1991 @Antreesy