-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore acl ui in sharing tab #2736
Conversation
More modern approach with the vue rewrite would be a separate entrypoint to register dav properties that is loaded early https://github.com/nextcloud/files_lock/blob/main/src/init.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works, just CI isn't happy yet
Crashes my activity tab 🤷 |
I tried with stable28 branch on all apps, this one for groupfolders, activity tab crashes on opening on a groupfolder:
|
Signed-off-by: Robin Appelman <robin@icewind.nl>
a101569
to
193ccb3
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
warning should be fixed with the dependency updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested against server master (Files + Groupfolders only), works as expected, saw nothing related in the console
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
9206ce6
to
229c120
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
75888e8
to
3846aa4
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
/backport to stable28 |
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28 Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Fixes #2637
This can probably use some larger rework to make thing modern™ but for now this seems to fix things