Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(developer): Deprecate OC.dialogs #11716

Merged
merged 1 commit into from
Apr 11, 2024
Merged

fix(developer): Deprecate OC.dialogs #11716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_30.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,16 @@ Deprecated APIs

* ``OC.dialogs.fileexists`` was already deprecated in Nextcloud 29, but is now also marked as such.
Use ``openConflictPicker`` from `@nextcloud/upload <https://nextcloud-libraries.github.io/nextcloud-upload/functions/openConflictPicker.html>`_ instead.
* Most ``OC.dialogs`` API is now deprecated and will be removed in the future. For generic dialogs use the ``DialogBuilder`` from the :ref:`js-library_nextcloud-dialogs`.
A list of the now deprecated methods:

* ``OC.dialogs.alert``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we list the alternatives or is everything replaced by the DialogBuilder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is replaced with it

* ``OC.dialogs.info``
* ``OC.dialogs.confirm``
* ``OC.dialogs.confirmDestructive``
* ``OC.dialogs.confirmHtml``
* ``OC.dialogs.prompt``
* ``OC.dialogs.message``

Back-end changes
----------------
Expand Down
2 changes: 2 additions & 0 deletions developer_manual/digging_deeper/javascript-apis.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ This package provides an `Axios <https://www.npmjs.com/package/axios>`_ HTTP cli

This package provides a simple event bus implementation that integrates with server and other apps. Thus it is one of the recommended ways of inter-app communication. Documentation: https://nextcloud-libraries.github.io/nextcloud-event-bus/

.. _js-library_nextcloud-dialogs:

``@nextcloud/dialogs``
^^^^^^^^^^^^^^^^^^^^^^

Expand Down
Loading