Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(developer): Deprecate OC.dialogs #11716

Merged
merged 1 commit into from
Apr 11, 2024
Merged

fix(developer): Deprecate OC.dialogs #11716

merged 1 commit into from
Apr 11, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 9, 2024

@susnux susnux added this to the Nextcloud 30 milestone Apr 9, 2024
@susnux susnux mentioned this pull request Apr 9, 2024
Merged
5 tasks
@susnux susnux requested review from st3iny and ChristophWurst April 10, 2024 22:12
ChristophWurst
ChristophWurst reviewed Apr 11, 2024
View reviewed changes
developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_30.rst
* Most ``OC.dialogs`` API is now deprecated and will be removed in the future. For generic dialogs use the ``DialogBuilder`` from the :ref:`js-library_nextcloud-dialogs`.
A list of the now deprecated methods:

* ``OC.dialogs.alert``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we list the alternatives or is everything replaced by the DialogBuilder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is replaced with it

@st3iny
Copy link
Member

st3iny commented Apr 11, 2024

Conflicts though

@susnux
fix(developer): Deprecate OC.dialogs
636fdc0 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/deprecate-oc-dialogs-functions branch from 47b39e3 to 636fdc0 Compare April 11, 2024 12:04
@susnux
Copy link
Contributor Author

susnux commented Apr 11, 2024

Conflicts though

Resolved

image

@susnux susnux merged commit b65fb2e into master Apr 11, 2024
11 checks passed
@susnux susnux deleted the fix/deprecate-oc-dialogs-functions branch April 11, 2024 12:08
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@st3iny st3iny st3iny approved these changes

Assignees
No one assigned
Labels
3. to review bug feedback-requested waiting for code merge
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @st3iny @ChristophWurst