Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Avoid fetching labels and owner details on permission check #6010

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jun 20, 2024

Save some queries as well as a decent amount of CPU time when checking card permissions during file system setup for deck shares.

On our instance this is around 5% of total CPU time in a 1h sample during non-peak times.

Screenshot 2024-06-20 at 08 31 52

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@juliusknorr
Copy link
Member Author

Running integration tests locally reduces the query count, checking in another PR.

@nextcloud nextcloud deleted a comment from github-actions bot Jun 20, 2024
@juliusknorr juliusknorr force-pushed the perf/permission-skip-enhance branch from a7ef797 to 2b70479 Compare June 20, 2024 08:33

This comment was marked as resolved.

@juliusknorr
Copy link
Member Author

Also on #6011, need to update the baseline

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the perf/permission-skip-enhance branch from 2b70479 to d4ea088 Compare June 25, 2024 15:01
@juliusknorr juliusknorr merged commit 02f63d9 into main Jun 26, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants