perf: Avoid fetching labels and owner details on permission check

Signed-off-by: Julius Härtl <jus@bitgrid.net>
nextcloud · Jun 25, 2024 · d4ea088 · d4ea088
1 parent ea4655b
commit d4ea088
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/lib/Db/CardMapper.php b/lib/Db/CardMapper.php
@@ -113,7 +113,7 @@ public function markNotified(Card $card): Entity {
 		return parent::update($cardUpdate);
 	}
 
-	public function find($id): Card {
+	public function find($id, bool $enhance = true): Card {
 		$qb = $this->db->getQueryBuilder();
 		$qb->select('*')
 			->from('deck_cards')
@@ -122,9 +122,11 @@ public function find($id): Card {
 			->addOrderBy('id');
 		/** @var Card $card */
 		$card = $this->findEntity($qb);
-		$labels = $this->labelMapper->findAssignedLabelsForCard($card->getId());
-		$card->setLabels($labels);
-		$this->mapOwner($card);
+		if ($enhance) {
+			$labels = $this->labelMapper->findAssignedLabelsForCard($card->getId());
+			$card->setLabels($labels);
+			$this->mapOwner($card);
+		}
 		return $card;
 	}
 

diff --git a/lib/Service/PermissionService.php b/lib/Service/PermissionService.php
@@ -119,7 +119,7 @@ public function checkPermission(?IPermissionMapper $mapper, $id, int $permission
 		if ($permissions[$permission] === true) {
 
 			if (!$allowDeletedCard && $mapper instanceof CardMapper) {
-				$card = $mapper->find((int)$id);
+				$card = $mapper->find((int)$id, false);
 				if ($card->getDeletedAt() > 0) {
 					throw new NoPermissionException('Card is deleted');
 				}