Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix icon-contacts-dark #2340

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Fix icon-contacts-dark #2340

merged 1 commit into from
Jul 8, 2021

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jul 8, 2021 •
edited
Loading

@skjnldsv
Fix icon-contacts-dark
73261c5 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv requested a review from szaimen July 8, 2021 09:06
@skjnldsv skjnldsv self-assigned this Jul 8, 2021
@skjnldsv skjnldsv added 3. to review Waiting for reviews bug Something isn't working design Related to the design labels Jul 8, 2021
@skjnldsv skjnldsv added this to the next milestone Jul 8, 2021
@codecov
Copy link

codecov bot commented Jul 8, 2021 •
edited
Loading

Codecov Report

Merging #2340 (96271d8) into master (208f688) will not change coverage.
The diff coverage is n/a.

❗ Current head 96271d8 differs from pull request most recent head 73261c5. Consider uploading reports for the commit 73261c5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2340   +/-   ##
=========================================
  Coverage     69.55%   69.55%           
  Complexity      238      238           
=========================================
  Files            22       22           
  Lines           680      680           
=========================================
  Hits            473      473           
  Misses          207      207

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 208f688...73261c5. Read the comment docs.

szaimen
szaimen approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but didn't test

@skjnldsv skjnldsv merged commit 1db81a6 into master Jul 8, 2021
@skjnldsv skjnldsv deleted the fix/icons-dark branch July 8, 2021 11:27
@szaimen
Copy link
Contributor

szaimen commented Jul 13, 2021

@skjnldsv do you mind creating a new minor release for this patch and #2341?
Would be great, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working design Related to the design
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.

Dark contactsmenu icon in files and contacts app
2 participants
@skjnldsv @szaimen