Dark contactsmenu icon in files and contacts app

[szaimen]

With the latest release of the contacts app, the contactsmenu icon looks inverted in the files and contacts app on c.nc.c:

I think this is due to the newly added icon import here

contacts/css/icons.scss

Line 36 in d970d5d

@include icon-black-white('contacts', 'contacts', 1);

which overwrites the icon that is inserted via the core css and displays it in the wrong color. Can we fix this by simply removing this import or is a different fix needed?

[szaimen]

@skjnldsv as this currently looks pretty bad in the files app on NC22 on c.nc.c, do you have some feedback on this?

[skjnldsv]

22 is bundled already, we should fix in contacts.
I guess just making sure that it's properly defined to white my default instead or adding an exclusion rule?

[szaimen]

Hm, how to do that? I wanted to fix it in the contacts app by removing the line that I mentioned in the description. But I am not sure if this breaks things...

[skjnldsv]

It will for everything that uses icon-contacts.
I guess it should be replacing icon-contacts in contacts with icon-contacts-dark

[szaimen]

ah okay, I am preparing a PR

[szaimen]

Only problem that I see is that the admin needs to run maintenance:repair after updating the contacts app to make this change visible... But I guess there is no way around it...

[skjnldsv]

Only problem that I see is that the admin needs to run maintenance:repair after updating the contacts app to make this change visible... But I guess there is no way around it...

Cache will expire and get recompiled after a bit, maintenance:repair is not always needed.

[szaimen]

Cache will expire and get recompiled after a bit, maintenance:repair is not always needed.

Good to know :)

[szaimen]

I can still reproduce that so it seems like #2331 didn't fix the issue...