Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal links don't work with public shares #1275

Closed
chmac opened this issue May 18, 2024 · 8 comments · Fixed by #1369
Closed

Internal links don't work with public shares #1275

chmac opened this issue May 18, 2024 · 8 comments · Fixed by #1369
Assignees
Labels
bug Something isn't working

Comments

@chmac
Copy link

chmac commented May 18, 2024

Describe the bug
When sharing a collective publicly, internal links within the collective do not work.

To Reproduce
Steps to reproduce the behavior:

  1. Create a collective with 2 pages
  2. Add a link on page 1 to page 2
  3. Share the collective
  4. Open the shared link in a private window

Expected behavior
I would expect internal links to work with the same sharing permissions as the shared link.

Server details:

  • Collectives app version: 2.11.0
  • Nextcloud version: 29.0.0
@chmac chmac added the bug Something isn't working label May 18, 2024
@mejo- mejo- self-assigned this Jun 5, 2024
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Jun 5, 2024
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Jun 5, 2024
@estux
Copy link

estux commented Jun 26, 2024

Hello, I'm experiencing the same bug.
I have a public share and have a page with some links to other pages of the same Collective.
Whenever I click on the links the result is a blank page (with only Nextcloud background visible).
But if I reload the page (using the browser "Reload page" feature) the destination page is shown.
I hope this helps

@xavi-GH
Copy link

xavi-GH commented Jul 11, 2024

Describe the bug When sharing a collective publicly, internal links within the collective do not work.

To Reproduce Steps to reproduce the behavior:

1. Create a collective with 2 pages

2. Add a link on page 1 to page 2

3. Share the collective

4. Open the shared link in a private window

Expected behavior I would expect internal links to work with the same sharing permissions as the shared link.

Server details:

* Collectives app version: 2.11.0

* Nextcloud version: 29.0.0

As a workaround, one can select directly the .md file:
Clip icon -> Link to file or folder -> select directly the ".md" file of the page:
(tested in NCv27, Collectives: 2.12.0)

Find attached this small screencap. :

NC_Collectives-bug-public_links.mp4

In "Other methods", the first 3 produce this output:
Screenshot_20240711_180727

@mejo- mejo- moved this from 📄 To do (~10 entries) to 🏗️ In progress in 📝 Office team Jul 16, 2024
mejo- added a commit that referenced this issue Jul 16, 2024
Allow to resolve page references by share token to support lookups from
public shares. This adds link previews for links to other pages in the
same collective in public shares.

It requires the new public reference API from nextcloud/server#46378 and
the Text app being built with nextcloud-libraries/nextcloud-vue#5800.

Fixes: #1275
Contributes to nextcloud/text#5520

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Jul 16, 2024
Allow to resolve page references by share token to support lookups from
public shares. This adds link previews for links to other pages in the
same collective in public shares.

It requires the new public reference API from nextcloud/server#46378 and
the Text app being built with nextcloud-libraries/nextcloud-vue#5800.

Fixes: #1275
Contributes to nextcloud/text#5520

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Jul 17, 2024
Allow to resolve page references by share token to support lookups from
public shares. This adds link previews for links to other pages in the
same collective in public shares.

It requires the new public reference API from nextcloud/server#46378 and
the Text app being built with nextcloud-libraries/nextcloud-vue#5800.

Fixes: #1275
Contributes to nextcloud/text#5520

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- moved this from 🏗️ In progress to 👀 In review in 📝 Office team Jul 23, 2024
@mejo- mejo- moved this from 👀 In review to 🏗️ In progress in 📝 Office team Jul 23, 2024
mejo- added a commit that referenced this issue Jul 24, 2024
Allow to resolve page references by share token to support lookups from
public shares. This adds link previews for links to other pages in the
same collective in public shares.

It requires the new public reference API from nextcloud/server#46378 and
the Text app being built with nextcloud-libraries/nextcloud-vue#5800.

Fixes: #1275
Contributes to nextcloud/text#5520

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Jul 24, 2024
Allow to resolve page references by share token to support lookups from
public shares. This adds link previews for links to other pages in the
same collective in public shares.

It requires the new public reference API from nextcloud/server#46378 and
the Text app being built with nextcloud-libraries/nextcloud-vue#5800.

Fixes: #1275
Contributes to nextcloud/text#5520

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Jul 24, 2024
Allow to resolve page references by share token to support lookups from
public shares. This adds link previews for links to other pages in the
same collective in public shares.

It requires the new public reference API from nextcloud/server#46378 and
the Text app being built with nextcloud-libraries/nextcloud-vue#5800.

Fixes: #1275
Contributes to nextcloud/text#5520

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- closed this as completed in d90167f Jul 24, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📝 Office team Jul 24, 2024
@chmac
Copy link
Author

chmac commented Aug 14, 2024

@mejo- Thanks for fixing this, that's awesome. Do you know when the changes will land in Nextcloud? I've just updated and I'm still seeing this issue, so I figure maybe it's not yet in the release I'm running?

@mejo-
Copy link
Member

mejo- commented Aug 14, 2024

@chmac unfortunately this will only work with Nextcloud 30 or newer. Nextcloud 30 is about to be released on 14. September.

@chmac
Copy link
Author

chmac commented Aug 14, 2024

@mejo- Sweet, thanks for the clarification. It will be a big help to our use case, happy to wait a bit for the release. 🧡

@chmac
Copy link
Author

chmac commented Sep 23, 2024

@mejo- We're live on Nextcloud 30 now, and I have Collectives v2.14.3, but I'm not sure if this change is included in that version or not. I've tried to check the commit log on main, but I can't figure it out. This fix is in main, but I don't know enough about how the app is built to know if main is now v2.14.3 or not. Do you know which version of Collectives will have this fix in it?

@mejo-
Copy link
Member

mejo- commented Sep 24, 2024

@chmac this should work with Nextcloud 30.0.0 and latest Collectives. If not, could you take a look at the network tab in your developer tools and the console if there's any errors? Also, did you force-reload to make sure the client cache got cleared?

@chmac
Copy link
Author

chmac commented Sep 24, 2024

@mejo- Okay, I think that it's working! I realise I might have been creating the wrong kind of links. My links were like /f/{ID}. But now I tried the "smart picker" and then I could choose the same page and the inserted link was completely different. That style of link works now. Thanks a lot. 🧡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants