-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal links don't work with public shares #1275
Comments
Hello, I'm experiencing the same bug. |
As a workaround, one can select directly the .md file: Find attached this small screencap. : NC_Collectives-bug-public_links.mp4 |
Allow to resolve page references by share token to support lookups from public shares. This adds link previews for links to other pages in the same collective in public shares. It requires the new public reference API from nextcloud/server#46378 and the Text app being built with nextcloud-libraries/nextcloud-vue#5800. Fixes: #1275 Contributes to nextcloud/text#5520 Signed-off-by: Jonas <jonas@freesources.org>
Allow to resolve page references by share token to support lookups from public shares. This adds link previews for links to other pages in the same collective in public shares. It requires the new public reference API from nextcloud/server#46378 and the Text app being built with nextcloud-libraries/nextcloud-vue#5800. Fixes: #1275 Contributes to nextcloud/text#5520 Signed-off-by: Jonas <jonas@freesources.org>
Allow to resolve page references by share token to support lookups from public shares. This adds link previews for links to other pages in the same collective in public shares. It requires the new public reference API from nextcloud/server#46378 and the Text app being built with nextcloud-libraries/nextcloud-vue#5800. Fixes: #1275 Contributes to nextcloud/text#5520 Signed-off-by: Jonas <jonas@freesources.org>
Allow to resolve page references by share token to support lookups from public shares. This adds link previews for links to other pages in the same collective in public shares. It requires the new public reference API from nextcloud/server#46378 and the Text app being built with nextcloud-libraries/nextcloud-vue#5800. Fixes: #1275 Contributes to nextcloud/text#5520 Signed-off-by: Jonas <jonas@freesources.org>
Allow to resolve page references by share token to support lookups from public shares. This adds link previews for links to other pages in the same collective in public shares. It requires the new public reference API from nextcloud/server#46378 and the Text app being built with nextcloud-libraries/nextcloud-vue#5800. Fixes: #1275 Contributes to nextcloud/text#5520 Signed-off-by: Jonas <jonas@freesources.org>
Allow to resolve page references by share token to support lookups from public shares. This adds link previews for links to other pages in the same collective in public shares. It requires the new public reference API from nextcloud/server#46378 and the Text app being built with nextcloud-libraries/nextcloud-vue#5800. Fixes: #1275 Contributes to nextcloud/text#5520 Signed-off-by: Jonas <jonas@freesources.org>
@mejo- Thanks for fixing this, that's awesome. Do you know when the changes will land in Nextcloud? I've just updated and I'm still seeing this issue, so I figure maybe it's not yet in the release I'm running? |
@chmac unfortunately this will only work with Nextcloud 30 or newer. Nextcloud 30 is about to be released on 14. September. |
@mejo- Sweet, thanks for the clarification. It will be a big help to our use case, happy to wait a bit for the release. 🧡 |
@mejo- We're live on Nextcloud 30 now, and I have Collectives v2.14.3, but I'm not sure if this change is included in that version or not. I've tried to check the commit log on main, but I can't figure it out. This fix is in main, but I don't know enough about how the app is built to know if main is now v2.14.3 or not. Do you know which version of Collectives will have this fix in it? |
@chmac this should work with Nextcloud 30.0.0 and latest Collectives. If not, could you take a look at the network tab in your developer tools and the console if there's any errors? Also, did you force-reload to make sure the client cache got cleared? |
@mejo- Okay, I think that it's working! I realise I might have been creating the wrong kind of links. My links were like |
Describe the bug
When sharing a collective publicly, internal links within the collective do not work.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I would expect internal links to work with the same sharing permissions as the shared link.
Server details:
The text was updated successfully, but these errors were encountered: