-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NcRichText): Call public reference API when unauthenticated #5800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
force-pushed
the
feat/public_reference
branch
from
July 10, 2024 09:59
61f75c2
to
623d338
Compare
mejo-
added a commit
to nextcloud/collectives
that referenced
this pull request
Jul 16, 2024
Allow to resolve page references by share token to support lookups from public shares. This adds link previews for links to other pages in the same collective in public shares. It requires the new public reference API from nextcloud/server#46378 and the Text app being built with nextcloud-libraries/nextcloud-vue#5800. Fixes: #1275 Contributes to nextcloud/text#5520 Signed-off-by: Jonas <jonas@freesources.org>
3 tasks
mejo-
added a commit
to nextcloud/collectives
that referenced
this pull request
Jul 16, 2024
Allow to resolve page references by share token to support lookups from public shares. This adds link previews for links to other pages in the same collective in public shares. It requires the new public reference API from nextcloud/server#46378 and the Text app being built with nextcloud-libraries/nextcloud-vue#5800. Fixes: #1275 Contributes to nextcloud/text#5520 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
feat/public_reference
branch
from
July 17, 2024 13:19
623d338
to
d89cd25
Compare
mejo-
added a commit
to nextcloud/collectives
that referenced
this pull request
Jul 17, 2024
Allow to resolve page references by share token to support lookups from public shares. This adds link previews for links to other pages in the same collective in public shares. It requires the new public reference API from nextcloud/server#46378 and the Text app being built with nextcloud-libraries/nextcloud-vue#5800. Fixes: #1275 Contributes to nextcloud/text#5520 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Jul 17, 2024
susnux
reviewed
Jul 18, 2024
juliusknorr
approved these changes
Jul 18, 2024
julien-nc
requested changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpick but LGTM
mejo-
force-pushed
the
feat/public_reference
branch
from
July 22, 2024 12:42
d89cd25
to
1b4020a
Compare
/backport to next |
mejo-
force-pushed
the
feat/public_reference
branch
from
July 22, 2024 12:47
1b4020a
to
a1d9c93
Compare
susnux
reviewed
Jul 22, 2024
julien-nc
approved these changes
Jul 22, 2024
* Depends on nextcloud/server#46378 * Contributes to nextcloud/server#45978 Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
feat/public_reference
branch
from
July 22, 2024 13:25
a1d9c93
to
d39b28a
Compare
2 tasks
Antreesy
added
enhancement
New feature or request
feature: richtext
Related to the richtext component
labels
Jul 22, 2024
mejo-
added a commit
to nextcloud/collectives
that referenced
this pull request
Jul 24, 2024
Allow to resolve page references by share token to support lookups from public shares. This adds link previews for links to other pages in the same collective in public shares. It requires the new public reference API from nextcloud/server#46378 and the Text app being built with nextcloud-libraries/nextcloud-vue#5800. Fixes: #1275 Contributes to nextcloud/text#5520 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
to nextcloud/collectives
that referenced
this pull request
Jul 24, 2024
Allow to resolve page references by share token to support lookups from public shares. This adds link previews for links to other pages in the same collective in public shares. It requires the new public reference API from nextcloud/server#46378 and the Text app being built with nextcloud-libraries/nextcloud-vue#5800. Fixes: #1275 Contributes to nextcloud/text#5520 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
to nextcloud/collectives
that referenced
this pull request
Jul 24, 2024
Allow to resolve page references by share token to support lookups from public shares. This adds link previews for links to other pages in the same collective in public shares. It requires the new public reference API from nextcloud/server#46378 and the Text app being built with nextcloud-libraries/nextcloud-vue#5800. Fixes: #1275 Contributes to nextcloud/text#5520 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
to nextcloud/collectives
that referenced
this pull request
Jul 24, 2024
Allow to resolve page references by share token to support lookups from public shares. This adds link previews for links to other pages in the same collective in public shares. It requires the new public reference API from nextcloud/server#46378 and the Text app being built with nextcloud-libraries/nextcloud-vue#5800. Fixes: #1275 Contributes to nextcloud/text#5520 Signed-off-by: Jonas <jonas@freesources.org>
This was referenced Aug 14, 2024
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
enhancement
New feature or request
feature: richtext
Related to the richtext component
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏁 Checklist
next
requested with a Vue 3 upgrade