-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcSelect): Ensure component height is same as input element #5883
Conversation
…r NcSelect with users Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
e56c883
to
ca340e4
Compare
Is it supposed to be |
Where do you see that number? It should be always |
Ok yeah my bad, tested it on 30 and looks good. But we will have to update some styling in calendar @ChristophWurst as it breaks |
/backport to next |
Seem now to become an issue on 28/29 |
☑️ Resolves
Currently the element was 36px instead of 34px which looks weird if using multiple input elements side by side (caused by search input being 34px + 2px border).
Also there was jumping because there are two different border width, so we need to adjust the input height based on the outer border width and the margin of the selected options.
🏁 Checklist
next
requested with a Vue 3 upgrade