Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NcSelect jumps/resizes on focus #5874

Closed
ChristophWurst opened this issue Jul 26, 2024 · 5 comments
Closed

NcSelect jumps/resizes on focus #5874

ChristophWurst opened this issue Jul 26, 2024 · 5 comments
Labels
0. to triage bug Something isn't working design Design, UX, interface and interaction design feature: select Related to the NcSelect* components

Comments

@ChristophWurst
Copy link
Contributor

ChristophWurst commented Jul 26, 2024

Default Focus
Bildschirmfoto vom 2024-07-26 11-38-29 Bildschirmfoto vom 2024-07-26 11-38-32

Look at the elments below. They are pushed down.

The default border is thinner than the focus border. Do we need a negative margin of the diffence between the two borders? E.g. if the default border is 1px and focus is 2px, the element has to move up by 1px to make up for the increased size, and everything will stay at its place regardless of focus state.

@ChristophWurst ChristophWurst added bug Something isn't working design Design, UX, interface and interaction design feature: select Related to the NcSelect* components 0. to triage labels Jul 26, 2024
@ChristophWurst
Copy link
Contributor Author

@jancborchardt could you discuss this with your designers?

@jancborchardt
Copy link
Contributor

@marcoambrosini @susnux @ShGKme this also came up in a design review. How do we best fix this?

@jancborchardt jancborchardt moved this to 👓 Design review in 🖍 Design team Aug 6, 2024
@ShGKme
Copy link
Contributor

ShGKme commented Aug 6, 2024

@marcoambrosini @susnux @ShGKme this also came up in a design review. How do we best fix this?

Do you have it on the current @nextcloud/vue version?

@ShGKme
Copy link
Contributor

ShGKme commented Aug 6, 2024

@ChristophWurst
Copy link
Contributor Author

@ShGKme ShGKme closed this as completed Aug 6, 2024
@github-project-automation github-project-automation bot moved this from 👓 Design review to 🎉 Done in 🖍 Design team Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. to triage bug Something isn't working design Design, UX, interface and interaction design feature: select Related to the NcSelect* components
Projects
None yet
Development

No branches or pull requests

3 participants