Revert falcon detection changes #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Falcon::Server is loaded into the object space after the environment report is sent by the agent. However, evaluating File.basename($0) returns falcon in time.
kaylareopelle
requested review from
fallwith,
hannahramadan and
tannalynn
as code owners
fallwith
reviewed
Aug 5, 2024
fallwith
previously approved these changes
Aug 5, 2024
Co-authored-by: James Bunch <fallwith@gmail.com>
…agent into falcon-detection
hannahramadan
previously approved these changes
Aug 5, 2024
fallwith
previously approved these changes
Aug 5, 2024
kaylareopelle
commented
Aug 6, 2024
kaylareopelle
dismissed stale reviews from fallwith and hannahramadan
via
b47141e
SimpleCov Report
|
tannalynn
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Falcon::Serverclass is loaded into the object space after the environment report is sent by the agent. However, evaluatingFile.basename($0)returns 'falcon' in time.This was our initial approach: ebc74b5
Closes #2778