Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix falcon dispatcher detection #2778

Closed
kaylareopelle opened this issue Jul 25, 2024 · 5 comments · Fixed by #2795
Closed

Fix falcon dispatcher detection #2778

kaylareopelle opened this issue Jul 25, 2024 · 5 comments · Fixed by #2795
Assignees
Labels

Comments

@kaylareopelle
Copy link
Contributor

In our environment report, the falcon dispatcher is not being identified.

According to @prateeksen, the code never reaches this line

@workato-integration
Copy link

@prateeksen
Copy link
Contributor

@kaylareopelle I have done a little more digging and found that find_class_in_object_space method returns nil until the ::Falcon::Server class is actually loaded into the object space and server is started. And the twist here is that, by the time this class is loaded into object space, and find_class_in_object_space returns :falcon Environment report is already sent from the agent from here with nil value in dispatcher in environment report.
I tried to return :falcon without checking this if condition, but in that case agent's worker thread is not initiated and that got initiated when I fired a curl request on application.
Could you please look into it from here, why the agent's worker not initiated without calling find_class_in_object_space

@kaylareopelle
Copy link
Contributor Author

Hi @prateeksen, thanks for digging in! I'll take a look this week as part of my hero duties.

@kaylareopelle
Copy link
Contributor Author

Hi @prateeksen, what's the priority on this issue? I think we may need to include it in our regular planning cycle to make meaningful progress.

@prateeksen
Copy link
Contributor

Hi @kaylareopelle This is comparatively low priority than #2777.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants