Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Node.js 20 GHA updates #2787

Merged
merged 24 commits into from
Aug 7, 2024
Merged

CI: Node.js 20 GHA updates #2787

Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
0b1cf2c
Merge pull request #2726 from newrelic/dev
fallwith Jun 20, 2024
a9bf538
Merge pull request #2769 from newrelic/dev
kaylareopelle Jul 24, 2024
f902c14
Update actions/checkout
hannahramadan Jul 29, 2024
c5b2721
Update actions/upload-artifact
hannahramadan Jul 29, 2024
140526d
Update download/artifact and make upload/artifact names dynamic
hannahramadan Jul 29, 2024
d857a5b
Correct download/artifcat name
hannahramadan Jul 29, 2024
2516ae7
combine coverage report
hannahramadan Jul 29, 2024
c313480
Merge after jobs finish
hannahramadan Jul 29, 2024
86d7426
Fix formatting
hannahramadan Jul 29, 2024
a0eaf07
Name specifics
hannahramadan Jul 29, 2024
e91ebab
Dynamic gem manifest names
hannahramadan Jul 29, 2024
3b5a9ce
Update actions/cache
hannahramadan Jul 29, 2024
a571cda
Update actions/github-script
hannahramadan Jul 29, 2024
badb336
Update adriangl/check-new-commits-action
hannahramadan Jul 29, 2024
e76fb90
softprops/action-gh-release
hannahramadan Jul 29, 2024
a7d9b0b
Update kanga333/variable-mapper
hannahramadan Jul 29, 2024
df047ac
Use node20 for issue closer
hannahramadan Jul 29, 2024
b870524
Use node22 for simplecov
hannahramadan Jul 29, 2024
712658a
technote-space/workflow-conclusion-action
hannahramadan Jul 29, 2024
75bf4b9
SimpleCov use node 20
hannahramadan Jul 29, 2024
60739b7
Use Node.js 20
hannahramadan Jul 30, 2024
2ce0cea
Remove technote-space/workflow-conclusion-action
hannahramadan Jul 30, 2024
ee84b28
Merge branch 'dev' into ci_node_updates
hannahramadan Jul 30, 2024
235cbeb
undo kanga
hannahramadan Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/issue_closer/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ inputs:
description: 'A GitHub token with PR read and Issue close permissions'
required: true
runs:
using: 'node16'
using: 'node20'
main: 'dist/index.js'
2 changes: 1 addition & 1 deletion .github/actions/simplecov-report/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ inputs:
description: "GitHub token"
required: true
runs:
using: "node16"
using: "node20"
main: "dist/index.js"
26 changes: 22 additions & 4 deletions .github/versions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ ruby/setup-ruby:
:tag: v1.190.0
:sha: a6e6f86333f0a2523ece813039b8b4be04560854
actions/checkout:
:tag: v4.1.2
:sha: 9bb56186c3b09b4f86b1c65136769dd318469633
nga333/variable-mapper:
:tag: v4.1.7
:sha: 692973e3d937129bcbf40652eb9f2f61becf3332
kanga333/variable-mapper:
:tag: v0.3.0
:sha: 3681b75f5c6c00162721168fb91ab74925eaebcb
:sha: c140b458cb69bd8c9c5eccd41e83aadc597c1352 # This commit is not on the main branch. It uses Node.js 20, which is needed to stop deprecation warnings.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit points here: https://github.com/kanga333/variable-mapper/pull/109/files

Users are trying to get the maintainer to merge it in. I chimed in.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should stick with commits that at least belong to the repo and not to a fork. A feature branch might be ok, but I think we should draw the line at forks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The obvious exception would be a newrelic owned fork...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see how a fork might be a little too saucy. I don't really know how to get newrelic to fork something lol! I'll revert this. Are we comfortable creating a separate backlog issue for this one and revisiting? We could even move this action into our .github folder like how I was thinking with Create local technote-space/workflow-conclusion-action gha

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we comfortable

I'm not sure of what the deadline is and what happens when after the deadline. If the deadline is far away, we're comfortable. If the deadline being reached simply causes the action to be forced to run on a Node v20 runtime, we're comfortable. If the deadline is soon and/or it involves the action failing instead of simply running under v20, then we'll have to evaluate urgency.

I see at least these 5 ways forward (not listed in any intentional order) - all of which I am happy to respect the group consensus on:

  • Override me and go with this PR as-is. Perhaps throw me a bone and at least put a "TODO: " prefix in the .yml file's comment line and create a backlogged issue for the TODO.
  • Create the separate backlog issue and revisit as you mentioned.
  • Point to the fork instead of the original repo. It's really the mixing of 2 repos that I have an issue with. Unless we have a particularly strict process for allowlisting new actions repos, we could just point to the fork. Unfortunately the rake task isn't smart enough to handle switching repos and the workflow lines would need to be manually changed.
  • Fork the action under your name and point there until we can get the repo moved under newrelic/
  • Fork and vendor the action under .github as you mentioned

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Jan 6, 2025 is end of support. I'll remove this and add these comments to the ticket.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linked this convo to the kanga333 ticket.

actions/cache:
:tag: v3.3.1
:sha: 88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8
Expand All @@ -24,3 +24,21 @@ voxmedia/github-action-slack-notify-build:
Mercymeilya/last-workflow-status:
:tag: v0.3.3
:sha: 3418710aefe8556d73b6f173a0564d38bcfd9a43
actions/upload-artifact:
:tag: v4.3.4
:sha: 0b2256b8c012f0828dc542b3febcab082c67f72b
actions/download-artifact:
:tag: v4.1.8
:sha: fa0a91b85d4f404e444e00e005971372dc801d16
actions/cache:
:tag: v4.0.2
:sha: 0c45773b623bea8c8e75f6c82b208c3cf94ea4f9
actions/github-script:
:tag: v7.0.1
:sha: 60a0d83039c74a4aee543508d2ffcb1c3799cdea
adriangl/check-new-commits-action:
:tag: v1.0.7
:sha: e6471f4fda990ebdb3bf44726371e1ad45ac4d37
softprops/action-gh-release:
:tag: v2.0.8
:sha: c062e08bd532815e2082a85e87e3ef29c3e6d191
36 changes: 18 additions & 18 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
- uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # tag v4.1.2
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # tag v4.1.7

# - curl is needed for Curb
# - xslt is needed for older Nokogiris, RUBY_VERSION < 2.5
Expand All @@ -54,7 +54,7 @@ jobs:
ruby-version: ${{ matrix.ruby-version }}

- name: Set up mini-envs for ruby version
uses: kanga333/variable-mapper@3681b75f5c6c00162721168fb91ab74925eaebcb # tag v0.3.0
uses: kanga333/variable-mapper@c140b458cb69bd8c9c5eccd41e83aadc597c1352 # tag v0.3.0
with:
key: ${{ matrix.ruby-version }}
map: |
Expand All @@ -74,7 +74,7 @@ jobs:
- if: matrix.ruby-version == '2.4.10'
name: Cache mysql55
id: mysql55-cache
uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8 # tag v3.3.1
uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # tag v4.0.2
with:
path: /usr/local/mysql55
key: mysql55-install
Expand Down Expand Up @@ -103,9 +103,9 @@ jobs:
CI_FOR_PR: true

- name: Save coverage results
uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # tag v3.1.2
uses: actions/upload-artifact@0b2256b8c012f0828dc542b3febcab082c67f72b # tag v4.3.4
with:
name: coverage-report-unit-tests
name: coverage-report-unit-tests-${{ matrix.ruby-version }}-${{ env.rails }}
fallwith marked this conversation as resolved.
Show resolved Hide resolved
path: lib/coverage_*/.resultset.json


Expand Down Expand Up @@ -195,7 +195,7 @@ jobs:
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
- uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # tag v4.1.2
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # tag v4.1.7

# - curl is needed for Curb
# - xslt is needed for older Nokogiris, RUBY_VERSION < 2.5
Expand All @@ -216,7 +216,7 @@ jobs:
- if: matrix.ruby-version == '2.4.10'
name: Cache mysql55
id: mysql55-cache
uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8 # tag v3.3.1
uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # tag v4.0.2
with:
path: /usr/local/mysql55
key: mysql55-install
Expand Down Expand Up @@ -267,20 +267,20 @@ jobs:
uses: ./.github/actions/annotate

- name: Save coverage results
uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # tag v3.1.2
uses: actions/upload-artifact@0b2256b8c012f0828dc542b3febcab082c67f72b # tag v4.3.4
with:
name: coverage-report-multiverse
name: coverage-report-multiverse-${{ matrix.ruby-version }}-${{ matrix.multiverse }}
path: lib/coverage_*/.resultset.json
retention-days: 2

- name: Generate gem manifest
run: rake test:multiverse:gem_manifest

- name: Save gem manifest
uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # tag v3.1.2
uses: actions/upload-artifact@0b2256b8c012f0828dc542b3febcab082c67f72b # tag v4.3.4
with:
name: gem_manifest_${{ matrix.ruby-version }}.json
path: gem_manifest_${{ matrix.ruby-version }}.json
name: gem_manifest_${{ matrix.ruby-version }}_${{ matrix.multiverse }}.json
path: gem_manifest_${{ matrix.ruby-version }}_${{ matrix.multiverse }}.json
retention-days: 2


Expand All @@ -294,7 +294,7 @@ jobs:
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
- uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # tag v4.1.2
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # tag v4.1.7

- name: Install Ruby ${{ matrix.ruby-version }}
uses: ruby/setup-ruby@a6e6f86333f0a2523ece813039b8b4be04560854 # tag v1.190.0
Expand All @@ -321,9 +321,9 @@ jobs:
uses: ./.github/actions/annotate

- name: Save coverage results
uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # tag v3.1.2
uses: actions/upload-artifact@0b2256b8c012f0828dc542b3febcab082c67f72b # tag v4.3.4
with:
name: coverage-report-infinite-tracing
name: coverage-report-infinite-tracing-${{ matrix.ruby-version }}-infinite_tracing
path: lib/coverage_*/.resultset.json


Expand All @@ -342,13 +342,13 @@ jobs:
ruby-version: '3.3'
- run: bundle
- name: Download all workflow run artifacts
uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # tag v3.0.2
uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # tag v4.1.8
- name: Collate Coverage Results
run: bundle exec rake coverage:report
- name: Upload coverage results
uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # tag v3.1.2
uses: actions/upload-artifact@0b2256b8c012f0828dc542b3febcab082c67f72b # tag v4.3.4
with:
name: coverage-report-combined
name: coverage-report-combined-${{ matrix.ruby-version }}
path: lib/coverage_results
retention-days: 2
- name: Simplecov Report
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/ci_cron.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
- uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # tag v4.1.2
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # tag v4.1.7

# - curl is needed for Curb
# - xslt is needed for older Nokogiris, RUBY_VERSION < 2.5
Expand All @@ -55,7 +55,7 @@ jobs:
ruby-version: ${{ matrix.ruby-version }}

- name: Set up mini-envs for ruby version
uses: kanga333/variable-mapper@3681b75f5c6c00162721168fb91ab74925eaebcb # tag v0.3.0
uses: kanga333/variable-mapper@c140b458cb69bd8c9c5eccd41e83aadc597c1352 # tag v0.3.0
with:
key: ${{ matrix.ruby-version }}
map: |
Expand Down Expand Up @@ -96,7 +96,7 @@ jobs:
- if: matrix.ruby-version == '2.4.10' || matrix.ruby-version == '2.5.9' || matrix.ruby-version == '2.6.10'
name: Cache mysql55
id: mysql55-cache
uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8 # tag v3.3.1
uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # tag v4.0.2
with:
path: /usr/local/mysql55
key: mysql55-install
Expand Down Expand Up @@ -207,7 +207,7 @@ jobs:
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
- uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # tag v4.1.2
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # tag v4.1.7

# - curl is needed for Curb
# - xslt is needed for older Nokogiris, RUBY_VERSION < 2.5
Expand All @@ -227,7 +227,7 @@ jobs:
- if: matrix.ruby-version == '2.4.10'
name: Cache mysql55
id: mysql55-cache
uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8 # tag v3.3.1
uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # tag v4.0.2
with:
path: /usr/local/mysql55
key: mysql55-install
Expand Down Expand Up @@ -285,7 +285,7 @@ jobs:
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
- uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # tag v4.1.2
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # tag v4.1.7

- name: Install Ruby ${{ matrix.ruby-version }}
uses: ruby/setup-ruby@a6e6f86333f0a2523ece813039b8b4be04560854 # tag v1.190.0
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci_jruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
- uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # tag v4.1.2
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # tag v4.1.7

- name: Install JRuby
uses: ruby/setup-ruby@a6e6f86333f0a2523ece813039b8b4be04560854 # tag v1.190.0
Expand Down Expand Up @@ -46,7 +46,7 @@ jobs:
run: 'git config --global init.defaultBranch main'

- name: Check out the source code
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # tag v4.1.2
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # tag v4.1.7

- name: Install JRuby
uses: ruby/setup-ruby@a6e6f86333f0a2523ece813039b8b4be04560854 # tag v1.190.0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci_special.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
- uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # tag v4.1.2
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # tag v4.1.7

# - curl is needed for Curb
# - xslt is needed for older Nokogiris, RUBY_VERSION < 2.5
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/config_docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
ruby-version: 3.3

- name: Checkout code
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # tag v4.1.2
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # tag v4.1.7

- run: bundle

Expand Down Expand Up @@ -57,10 +57,10 @@ jobs:
if: failure()
steps:
- name: Checkout agent repository
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # tag v4.1.2
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # tag v4.1.7

- name: Checkout docs website repository
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # tag v4.1.2
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # tag v4.1.7
with:
repository: ${{ env.DESTINATION_REPO }}
token: ${{ secrets.NEWRELIC_RUBY_AGENT_BOT_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/label_community_cards.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Label community issue
uses: actions/github-script@d7906e4ad0b1822421a7e6a35d5ca353c962f410 # tag v6.4.1
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # tag v7.0.1
with:
script: |
github.rest.issues.addLabels({
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/performance_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:
outputs:
changed: ${{ steps.branch_change_output.outputs.has-new-commits }}
steps:
- uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # tag v4.1.2
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # tag v4.1.7
- name: check branch changes
id: branch_change_output
uses: adriangl/check-new-commits-action@6556947ca20c2047ed733894258186619b84d282 # tag v1.0.6
uses: adriangl/check-new-commits-action@e6471f4fda990ebdb3bf44726371e1ad45ac4d37 # tag v1.0.7
with:
seconds: 604800
branch: 'dev'
Expand All @@ -30,21 +30,21 @@ jobs:
run:
working-directory: ./test/performance
steps:
- uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # tag v4.1.2
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # tag v4.1.7
with:
ref: 'main'
- uses: ruby/setup-ruby@a6e6f86333f0a2523ece813039b8b4be04560854 # tag v1.190.0
with:
ruby-version: '3.3'
- run: bundle
- run: bundle exec script/runner -B
- uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # tag v4.1.2
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # tag v4.1.7
- run: bundle
- run: bundle exec script/runner -C -M > performance_results.md
- name: Save performance results
uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # tag v3.1.2
uses: actions/upload-artifact@0b2256b8c012f0828dc542b3febcab082c67f72b # tag v4.3.4
with:
name: performance-test-results
name: performance-test-results-${{ matrix.ruby-version }}
path: ./test/performance/performance_results.md
- name: Slack results
uses: adrey/slack-file-upload-action@903be3678c88966c762193f06530c39178b44d68 # tag v1.0.5
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr_closed.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
permissions: write-all
steps:
- name: Clone the repo
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # tag v4.1.2
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # tag v4.1.7
- name: issue_closer Action
uses: ./.github/actions/issue_closer # no tag - locally sourced
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/prerelease.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
ruby-version: 3.3

- name: Checkout code
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # tag v4.1.2
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # tag v4.1.7

- run: bundle

Expand Down Expand Up @@ -45,7 +45,7 @@ jobs:
LABEL: prerelease

- name: Create pre release tag
uses: softprops/action-gh-release@de2c0eb89ae2a093876385947365aca7b0e5f844 # tag v0.1.15
uses: softprops/action-gh-release@c062e08bd532815e2082a85e87e3ef29c3e6d191 # tag v2.0.8
with:
tag_name: ${{ env.prerelease_tag }}
name: ${{ env.prerelease_tag }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
contents: write
repository-projects: write
steps:
- uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # tag v4.1.2
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # tag v4.1.7
with:
fetch-depth: 0

Expand Down Expand Up @@ -42,7 +42,7 @@ jobs:
echo "VERSION=$(ls newrelic_rpm-*.gem | ruby -pe 'sub(/newrelic_rpm\-(.*).gem/, "\\1")')" >> $GITHUB_ENV

- name: Create github release
uses: softprops/action-gh-release@de2c0eb89ae2a093876385947365aca7b0e5f844 # tag v0.1.15
uses: softprops/action-gh-release@c062e08bd532815e2082a85e87e3ef29c3e6d191 # tag v2.0.8
if: $(git tag -l ${{ env.VERSION }}) == false
with:
tag_name: ${{ env.VERSION }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release_notes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
with:
ruby-version: 3.3
- name: Checkout code
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # tag v4.1.2
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # tag v4.1.7

- name: Generate release notes and environment variables
run: |
Expand Down Expand Up @@ -57,13 +57,13 @@ jobs:
if: failure()
steps:
- name: Checkout agent repository
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # tag v4.1.2
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # tag v4.1.7

- name: Get branch name
run: echo "branch_name=$(ruby -r $PWD/.github/workflows/scripts/generate_release_notes.rb -e GenerateReleaseNotes.new.branch_name)" >> $GITHUB_ENV

- name: Checkout docs website repository
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # tag v4.1.2
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # tag v4.1.7
with:
repository: newrelic/docs-website
token: ${{ secrets.NEWRELIC_RUBY_AGENT_BOT_TOKEN }}
Expand Down
Loading
Loading