-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Node.js 20 GHA updates #2787
Merged
Merged
Changes from 23 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
0b1cf2c
Merge pull request #2726 from newrelic/dev
fallwith a9bf538
Merge pull request #2769 from newrelic/dev
kaylareopelle f902c14
Update actions/checkout
hannahramadan c5b2721
Update actions/upload-artifact
hannahramadan 140526d
Update download/artifact and make upload/artifact names dynamic
hannahramadan d857a5b
Correct download/artifcat name
hannahramadan 2516ae7
combine coverage report
hannahramadan c313480
Merge after jobs finish
hannahramadan 86d7426
Fix formatting
hannahramadan a0eaf07
Name specifics
hannahramadan e91ebab
Dynamic gem manifest names
hannahramadan 3b5a9ce
Update actions/cache
hannahramadan a571cda
Update actions/github-script
hannahramadan badb336
Update adriangl/check-new-commits-action
hannahramadan e76fb90
softprops/action-gh-release
hannahramadan a7d9b0b
Update kanga333/variable-mapper
hannahramadan df047ac
Use node20 for issue closer
hannahramadan b870524
Use node22 for simplecov
hannahramadan 712658a
technote-space/workflow-conclusion-action
hannahramadan 75bf4b9
SimpleCov use node 20
hannahramadan 60739b7
Use Node.js 20
hannahramadan 2ce0cea
Remove technote-space/workflow-conclusion-action
hannahramadan ee84b28
Merge branch 'dev' into ci_node_updates
hannahramadan 235cbeb
undo kanga
hannahramadan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,5 +21,5 @@ inputs: | |
description: "GitHub token" | ||
required: true | ||
runs: | ||
using: "node16" | ||
using: "node20" | ||
main: "dist/index.js" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit points here: https://github.com/kanga333/variable-mapper/pull/109/files
Users are trying to get the maintainer to merge it in. I chimed in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should stick with commits that at least belong to the repo and not to a fork. A feature branch might be ok, but I think we should draw the line at forks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The obvious exception would be a
newrelic
owned fork...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see how a fork might be a little too saucy. I don't really know how to get newrelic to fork something lol! I'll revert this. Are we comfortable creating a separate backlog issue for this one and revisiting? We could even move this action into our
.github
folder like how I was thinking with Create local technote-space/workflow-conclusion-action ghaThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure of what the deadline is and what happens when after the deadline. If the deadline is far away, we're comfortable. If the deadline being reached simply causes the action to be forced to run on a Node v20 runtime, we're comfortable. If the deadline is soon and/or it involves the action failing instead of simply running under v20, then we'll have to evaluate urgency.
I see at least these 5 ways forward (not listed in any intentional order) - all of which I am happy to respect the group consensus on:
newrelic/
.github
as you mentionedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like Jan 6, 2025 is end of support. I'll remove this and add these comments to the ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linked this convo to the kanga333 ticket.