CI: Node.js 20 GHA updates

[hannahramadan]

Update the following actions to newer versions that use Node.js 20+

• actions/checkout - closes #2598
• actions/upload-artifact - closes #2599
• actions/download-artifact - closes #2600
• actions/cache - closes #2601
• actions/github-script - closes #2602
• adriangl/check-new-commits-action - closes #2604
• softprops/action-gh-release - closes #2605
• .github/actions/issue_closer - closes #2606

[hannahramadan]

This commit points here: https://github.com/kanga333/variable-mapper/pull/109/files

Users are trying to get the maintainer to merge it in. I chimed in.

[fallwith]

I think we should stick with commits that at least belong to the repo and not to a fork. A feature branch might be ok, but I think we should draw the line at forks.

[fallwith]

The obvious exception would be a newrelic owned fork...

[hannahramadan]

I see how a fork might be a little too saucy. I don't really know how to get newrelic to fork something lol! I'll revert this. Are we comfortable creating a separate backlog issue for this one and revisiting? We could even move this action into our .github folder like how I was thinking with Create local technote-space/workflow-conclusion-action gha

[fallwith]

Are we comfortable

I'm not sure of what the deadline is and what happens when after the deadline. If the deadline is far away, we're comfortable. If the deadline being reached simply causes the action to be forced to run on a Node v20 runtime, we're comfortable. If the deadline is soon and/or it involves the action failing instead of simply running under v20, then we'll have to evaluate urgency.

I see at least these 5 ways forward (not listed in any intentional order) - all of which I am happy to respect the group consensus on:

• Override me and go with this PR as-is. Perhaps throw me a bone and at least put a "TODO: " prefix in the .yml file's comment line and create a backlogged issue for the TODO.
• Create the separate backlog issue and revisit as you mentioned.
• Point to the fork instead of the original repo. It's really the mixing of 2 repos that I have an issue with. Unless we have a particularly strict process for allowlisting new actions repos, we could just point to the fork. Unfortunately the rake task isn't smart enough to handle switching repos and the workflow lines would need to be manually changed.
• Fork the action under your name and point there until we can get the repo moved under newrelic/
• Fork and vendor the action under .github as you mentioned

[hannahramadan]

Looks like Jan 6, 2025 is end of support. I'll remove this and add these comments to the ticket.

[hannahramadan]

Linked this convo to the kanga333 ticket.

[fallwith]

I think we should remove any references to forks and mark the relevant Node 20 upgrade effort(s) as blocked until the PRs are merged into the main (non-fork) repos.

[github-actions]

SimpleCov Report

	Coverage	Threshold
Line	93.87%	93%
Branch	70.55%	50%