Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Active Job notifications subscriber #1761

Merged
merged 3 commits into from
Jan 25, 2023
Merged

Active Job notifications subscriber #1761

merged 3 commits into from
Jan 25, 2023

Commits on Jan 25, 2023

  1. Active Job notifications subscriber 

    Subscribe to Active Job notifications and process the 7 (at the time of
Rails v7.1.0.0.alpha) related events to produce additional
instrumentation for the library.
    @fallwith
    fallwith committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    312d524 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into city_gardens

    @fallwith
    fallwith committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    8384db0 View commit details
    Browse the repository at this point in the history

  3. ActiveJob notifications PR feedback 

    - leverage the base NotificationsSubscriber class better
- standardize on NewRelic::UNKNOWN
- update test names
- simplify TODO comment
    @fallwith
    fallwith committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    6e2aaf5 View commit details
    Browse the repository at this point in the history