Active Job notifications subscriber #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subscribe to Active Job notifications and process the 7 (at the time of Rails v7.1.0.0.alpha) related events to produce additional instrumentation for the library.
fallwith
commented
Jan 25, 2023
| @@ -7,4 +7,11 @@ | |||
| # required Ruby >= 2.5.0 and Ruby 2.6.0 was marked for EOL | |||
| SIMPLECOV_MIN_RUBY_VERSION = '2.7.0' | |||
|
|
|||
| require 'simplecov' if RUBY_VERSION >= SIMPLECOV_MIN_RUBY_VERSION | |||
There was a problem hiding this comment.
Currently for some tests with some Rubies, we hit a "file not found" error, which can be puzzling because it's not obvious that there's a LoadError involved (no backtrace is provided) and passing things such as --trace won't reach the subshell used for the env tests.
To repro, simply use Ruby 2.7.5 to perform bundle exec rake test:env[rails52]. It's perfectly reasonable that Ruby 2.7.5 might be used in conjunction with Rails 5.2. But while Ruby 2.7+ will satisfy the SimpleCov helper check, the Rails 5.2 test env Gemfile does not specify simplecov.
Now we simply rescue and report load errors but don't let them stop the tests from running.
kaylareopelle
requested changes
Jan 25, 2023
test/new_relic/agent/instrumentation/rails/active_job_subscriber.rb
Outdated
Show resolved
Hide resolved
test/new_relic/agent/instrumentation/rails/active_job_subscriber.rb
Outdated
Show resolved
Hide resolved
test/new_relic/agent/instrumentation/rails/active_job_subscriber.rb
Outdated
Show resolved
Hide resolved
- leverage the base NotificationsSubscriber class better - standardize on NewRelic::UNKNOWN - update test names - simplify TODO comment
SimpleCov Report
|
kaylareopelle
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subscribe to Active Job notifications and process the 7 (at the time of Rails v7.1.0.0.alpha) related events to produce additional instrumentation for the library.
resolves #1515