Vertx 4.4.2 Postgresql SqlClient Instrumentation #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2004 +/- ##
=========================================
Coverage 70.60% 70.61%
Complexity 9872 9872
=========================================
Files 829 829
Lines 39914 39915 +1
Branches 6077 6077
=========================================
+ Hits 28181 28185 +4
+ Misses 9002 8999 -3
Partials 2731 2731 ☔ View full report in Codecov by Sentry. |
jbedell-newrelic
approved these changes
Aug 9, 2024
meiao
reviewed
Aug 9, 2024
...sqlclient-4.4.2/src/main/java/io/vertx/pgclient/impl/PgSocketConnection_Instrumentation.java
Outdated
Show resolved
Hide resolved
...sqlclient-4.4.2/src/main/java/com/nr/vertx/sqlclient/instrumentation/NRSqlClientWrapper.java
Show resolved
Hide resolved
meiao
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1747
Adds instrumentation for the vertx Postgres SqlClient to report PG related database calls.
Note that the module doesn't currently capture the executed SQL.