Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEWRELIC-5268 - recordCustomEvent log pattern now includes event type, key and value #1083

Merged
merged 1 commit into from
Nov 22, 2022
Merged

NEWRELIC-5268 - recordCustomEvent log pattern now includes event type, key and value #1083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions newrelic-agent/src/main/java/com/newrelic/agent/service/analytics/InsightsServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,8 +383,9 @@ private static CustomInsightsEvent createValidatedEvent(String eventType, Map<St

// key or value is null, skip it with a log message and iterate to next entry in attributes.entrySet()
if (key == null || value == null) {
Agent.LOG.log(Level.WARNING, "Custom event with invalid attributes key or value of null was reported for a transaction but ignored."
+ " Each key should be a String and each value should be a String, Number, or Boolean.");
Agent.LOG.log(Level.WARNING, "Custom event [{0}] with invalid attributes key or value of null was reported for a transaction but ignored."
+ " Each key should be a String and each value should be a String, Number, or Boolean. Key: {1} / Value: {2}",
eventType, (key == null ? "[null]" : key), (value == null ? "[null]" : value.toString()));
continue;
}

Expand Down