Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEWRELIC-5268 - recordCustomEvent log pattern now includes event type, key and value #1083

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

jtduffy
Copy link
Contributor

@jtduffy jtduffy commented Nov 16, 2022

Before contributing, please read our contributing guidelines and code of conduct.

Overview

InsightsServiceImpl.recordCustomEvent log pattern now includes event type, key and value

Related Github Issue

Include a link to the related GitHub issue, if applicable

Testing

The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,

Checks

[x] Are your contributions backwards compatible with relevant frameworks and APIs?
[ ] Does your code contain any breaking changes? Please describe.
[ ] Does your code introduce any new dependencies? Please describe.

@jtduffy jtduffy self-assigned this Nov 16, 2022
Copy link
Contributor

@tbradellis tbradellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jtduffy jtduffy changed the title recordCustomEvent log pattern now includes event type, key and value NEWRELIC-5268 - recordCustomEvent log pattern now includes event type, key and value Nov 17, 2022
@jtduffy jtduffy merged commit 9ea77d9 into main Nov 22, 2022
@jtduffy jtduffy deleted the record-custom-event-log-pattern branch November 22, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants