Remove whitespace from instrumentation parameters #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuqtran88
reviewed
Feb 12, 2021
| } | ||
|
|
||
| // void as the parameters means parameterless method call (not all overloads) | ||
| if (Strings::AreEqualCaseInsensitive(*(rawParams), _X("void"))) |
There was a problem hiding this comment.
This is not related to this PR but rather interesting to me. I don't know if void parameter is a thing in C#. It is a thing in C++ or C but we are instrumenting C# functions.
There was a problem hiding this comment.
I actually found my answer. Whatever method signatures we declare in the instrumetation xml are IL method signatures as opposed to C# or languages. So I believe void parameter is a thing in IL world.
|
We should add the newly built NewRelic.Profiler.dlls to _profilerBuild folders. |
|
Ran unit tests, Profiler tests, IntegrationTests. Looks good. |
lspangler584
approved these changes
Feb 16, 2021
nr-ahemsath
deleted the
remove-whitespace-from-instrumentation-parameters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #169 by removing whitespace characters from the parameter list in a custom instrumentation XML method matcher.
Testing
Added unit test for matching multiple parameters with a space between the comma and the second parameter type.
Manually tested custom instrumentation matching a method with multiple parameters, with spaces between the parameters in the list, like this:
Method in code:
static void doSomething(int aNumber, bool aBool, string aString)Method matcher in CI XML:
<exactMethodMatcher methodName="doSomething" parameters="System.Int32, System.Boolean, System.String" />Tested on both Windows and Linux. With the current released profiler, this CI would not match and this method would not be instrumented. With the profiler built from this PR branch, the CI matches the method and the method is instrumented.
Changelog
Updated changelog.