Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiler should be able to match method parameters from XML that contain a space. Trim it ! #169

Closed
angelatan2 opened this issue Sep 1, 2020 · 0 comments · Fixed by #461
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@angelatan2
Copy link
Contributor

angelatan2 commented Sep 1, 2020

Description
The following XML won't match ONLY because there is a space after the comma in the method parameters.

We should trim the whitespace to be more forgiving to ourselves and, more importantly, our clients doing custom instrumentation.

<match assemblyName="RestSharp" className="RestSharp.RestClient">
<exactMethodMatcher methodName="ExecuteTaskAsync" parameters="RestSharp.IRestRequest,System.Threading.CancellationToken" />
</match>

Expected Behavior
Ignore whitespace for method parameters.

Steps to Reproduce

Your Environment

Additional context
Migrated from the original issue.

@angelatan2 angelatan2 added bug Something isn't working good first issue Good for newcomers labels Sep 1, 2020
@nr-ahemsath nr-ahemsath self-assigned this Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants